1316382 - provide ability to view deleted files in diffs

Status: RESOLVED DUPLICATE of bug 1114997

(MozReview Graveyard :: General, defect)

Description

[Nathan Froyd [:froydnj]]

For changesets that have deleted files in them, mozreview currently says "This file was deleted. The content cannot be displayed."

It is often useful to be able to look at the contents of the deleted files to be able to answer the question of whether they should be deleted or not.  Splinter provides this, raw diffs coming out of hg provide this, mozreview ought to be able to provide this too.  mozreview makes it relatively easy to display context on diffs so I don't have to go find the file in my editor or in DXR; it should make it equally easy to view files being deleted as well.  I shouldn't have to go rooting around for the raw diff just to figure out what's going on.

Make this capability optional if you like ("click here to display the contents of the deleted file" or somesuch) to avoid problems with deleting binary files.  But to not provide the ability to see such files makes reviewing much harder than it ought to be.

Comment 1

[Mark Côté [:mcote]]

Yeah, this is a big deficiency in Review Board.  Apparently they've fixed it in their upcoming 3.0 release.