1316385 - wasm: generate bounds check the same way in debug/opt builds

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect, P3)

Description

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: wasm-check-bce.patch

Bug 1315596 wasn't triggering under a debug build because a redundant check was generated anyways and this perturbed the register allocation patterns. I think using debug vs opt mode shouldn't have an impact here; in particular, this might hide a few fuzz bugs.

Here's a patch offering a new option for the shell (--wasm-check-bce) as well as the env option (JITOPTIONS_wasmAlwaysCheckBounds) to trigger the old behavior.

It's enabled on the wasm/memory and wasm/bce tests; but really we could use it for all the tests by including it in the directives.txt file (thanks Lars!).

Comment 1

[Luke Wagner [:luke]]

Comment on attachment 8809096 [details] [diff] [review]
wasm-check-bce.patch

Review of attachment 8809096 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

::: js/src/jit-test/jit_test.py
@@ +200,5 @@
>      # wasm-baseline run when requesting --jitflags=interp, but the test
>      # contains test-also-noasmjs.)
>      test_flags = get_jitflags(options.jitflags)
>      options.can_test_also_noasmjs = True
> +    options.can_test_also_wasm = True

Perhaps instead we could name 'asmjs_disabled'/'wasm_disabled'?

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/07bbb0e3dde4
Add an env option to always enable wasm bounds check generation; r=luke

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/07bbb0e3dde4