Intermittent toolkit/components/extensions/test/mochitest/test_chrome_ext_downloads_saveAs.html | file was not downloaded
Categories
(WebExtensions :: General, defect, P3)
Tracking
(Not tracked)
People
(Reporter: intermittent-bug-filer, Assigned: robwu)
References
(Depends on 1 open bug)
Details
(Keywords: bulk-close-intermittents, intermittent-failure, Whiteboard: [stockwell unknown])
Filed by: philringnalda [at] gmail.com https://treeherder.mozilla.org/logviewer.html#?job_id=6389666&repo=autoland https://archive.mozilla.org/pub/firefox/tinderbox-builds/autoland-win32/1478701581/autoland_win7_ix_test-mochitest-other-bm126-tests1-windows-build285.txt.gz
Updated•8 years ago
|
Updated•7 years ago
|
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 4•6 years ago
|
||
https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
Comment 5•6 years ago
|
||
Recent failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=163903007&repo=mozilla-inbound&lineNumber=7142
Comment hidden (Intermittent Failures Robot) |
Comment 7•6 years ago
|
||
https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
Comment 8•6 years ago
|
||
Recent failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=171362442&repo=mozilla-central&lineNumber=5391
Updated•6 years ago
|
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Updated•6 years ago
|
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 113•4 years ago
|
||
Shane, any idea what's going wrong here? Is the remove operation of the file saved before not complete yet?
Comment hidden (Intermittent Failures Robot) |
Comment 115•4 years ago
|
||
The increase in frequency seems to coincide with bug 1395207 landing a patch.
Comment 116•4 years ago
|
||
(In reply to Shane Caraveo (:mixedpuppy) from comment #115)
The increase in frequency seems to coincide with bug 1395207 landing a patch.
I think that the increase in frequency is because the patch for bug 1395207 added a lot more test cases. Looking at the older and recent failures, it appears that within testExpectFilePicker()
something goes wrong between:
pickerFile.remove(false);
and
ok(!pickerFile.exists(), "file was not downloaded");
I don't know what the root cause could be though, since the remove()
call is synchronous. Is there a way to find out if the test failures are always on Windows?
Comment 117•4 years ago
|
||
To see the list of failures and their platforms, go to the top of this page and expand the section "Details". There should be a "Orange Factor" graphic with a link to the right. Click that link.
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 126•4 years ago
•
|
||
As mentioned in comment 116, something goes wrong in this range: https://searchfox.org/mozilla-central/rev/dcd9c2d2bc19d96d487825eb70c2333a4d60994e/toolkit/components/extensions/test/mochitest/test_chrome_ext_downloads_saveAs.html#151-162
Specifically, after removing the file, it is unexpectedly recreated (on Windows).
In this code range, there is nothing that creates the file, so I guess that the file is (re)created by the download request from a few lines back (line 146).
The done
message from line 158 is in response to the downloads.onChanged
event with state
="complete" (via ext-downloads.js
), which is ultimately triggered via _notifyChange
near the end Download
's start
method.
After _notifyChange()
, there is a _succeed()
call, which calls DownloadIntegration.downloadDone()
, which does a bunch of stuff including writing an Alternative Data Stream to the file (which implicitly creates the file if it had been deleted): https://searchfox.org/mozilla-central/rev/227f22acef5c4865503bde9f835452bf38332c8e/toolkit/components/downloads/DownloadIntegration.jsm#589,611
I manually tested this by putting a breakpoint at the start of downloadDone
, calling browser.downloads.download
from an extension with a blob:-URL and dummy file name. When the file was downloaded, the breakpoint was triggered. I deleted the file in Explorer, resumed the execution and an empty file was created again.
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 129•4 years ago
|
||
In the last 7 days this bug failed 25 times. Happens on windows10-64, windows10-64-shippable, windows7-32 mostly opt build type.
Recent log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=312420059&repo=autoland&lineNumber=6351
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 131•4 years ago
|
||
Ideally bug 1654819 should be fixed.
If it doesn't then I would prefer monkey-patching https://searchfox.org/mozilla-central/rev/50cb0892948fb4291b9a6b1b30122100ec7d4ef2/toolkit/components/downloads/DownloadIntegration.jsm#520 to return false (to disable the logic at https://searchfox.org/mozilla-central/rev/50cb0892948fb4291b9a6b1b30122100ec7d4ef2/toolkit/components/downloads/DownloadIntegration.jsm#598 ) over disabling the test (I guess that would be the next step after "stockwell needswork:owner"? I'm already watching this bug anyway, so I guess that I own the bug?)
Comment 132•4 years ago
|
||
(In reply to Rob Wu [:robwu] from comment #131)
Ideally bug 1654819 should be fixed.
If it doesn't then I would prefer monkey-patching https://searchfox.org/mozilla-central/rev/50cb0892948fb4291b9a6b1b30122100ec7d4ef2/toolkit/components/downloads/DownloadIntegration.jsm#520 to return false (to disable the logic at https://searchfox.org/mozilla-central/rev/50cb0892948fb4291b9a6b1b30122100ec7d4ef2/toolkit/components/downloads/DownloadIntegration.jsm#598 ) over disabling the test (I guess that would be the next step after "stockwell needswork:owner"? I'm already watching this bug anyway, so I guess that I own the bug?)
stockwell needswork:owner - mostly refers to the triage owner and since you're watching/working on this I assume you're the assignee?
We disable the tests when they reach a 150 failures in the last 30 days and until then, poke people on the bugs.
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 134•4 years ago
|
||
I'm assigning the bug to myself because I know why it's happening and how it can be fixed (either a real fix via bug 1654819 or test-only bandaid according to comment 131).
Feel free to poke me to raise the priority if the frequency of failures become unpalatable.
Comment 135•4 years ago
|
||
(In reply to Rob Wu [:robwu] from comment #134)
I'm assigning the bug to myself because I know why it's happening and how it can be fixed (either a real fix via bug 1654819 or test-only bandaid according to comment 131).
Feel free to poke me to raise the priority if the frequency of failures become unpalatable.
Thank you. For now the failure rate is low, but we'll ni if it increases.
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 159•3 years ago
•
|
||
There have been 34 total failures in the last 7 days:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?startday=2021-01-17&endday=2021-01-24&tree=trunk&bug=1316394
Affected platforms are:
- windows7-32-shippable
- windows7-32 opt & debug
- windows10-64-shippable
- windows10-64 opt & debug
Recent log: https://treeherder.mozilla.org/logviewer?job_id=327597949&repo=autoland&lineNumber=116786
Comment hidden (Intermittent Failures Robot) |
Comment 161•3 years ago
|
||
Hi Rob, based on above comments, can you take a look?
Assignee | ||
Comment 162•3 years ago
|
||
I took a look (follow-up to comment 131 and comment 134) and posted my analysis plus proposed fix at https://bugzilla.mozilla.org/show_bug.cgi?id=1654819#c4
This week is reserved for other work (including a virtual All hands with my team), I'll save the needinfo for next week.
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 165•3 years ago
|
||
failure rate dropped again, I've reprioritized accordingly. If the rates jump again I'll reprioritize.
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Updated•3 years ago
|
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 183•2 years ago
|
||
disabled on win10 in bug 1695612, otherwise been no activity for a while.
Description
•