1316428 - Promise leaks window on fusion.net

Status: RESOLVED INVALID

(Core :: JavaScript Engine, defect, P3)

Description

[Ben Kelly [:bkelly, not reviewing]]

Attachment: memory-report.json.gz

I got a content window leak on 52.0a1 (2016-11-09) (64-bit) today:

│    ├──8.48 MB (03.13%) -- top(none)
│    │  ├──8.48 MB (03.12%) -- ghost/window(http://fusion.net/story/368544/students-protest-trump-presidency/)
│    │  │  ├──4.09 MB (01.51%) -- js-compartment(http://fusion.net/story/368405/how-polling-data-got-trump-clinton-so-wrong/)
│    │  │  │  ├──3.67 MB (01.35%) ++ classes
│    │  │  │  └──0.42 MB (00.15%) ++ (5 tiny)
│    │  │  ├──2.98 MB (01.10%) ── style-sheets
│    │  │  └──1.41 MB (00.52%) ++ (2 tiny)
│    │  └──0.00 MB (00.00%) ── detached/window(http://fusion.net/story/368405/how-polling-data-got-trump-clinton-so-wrong/)/dom/other

I got the gc/gc logs and it appears to be leaked through a Promise object:

$ grep nsGlobalWindow * | grep fusion
cc-edges.5660.1478724617.log:0000022920DEBC00 [rc=1248] nsGlobalWindow # 2147485761 inner http://fus
ion.net/story/368544/students-protest-trump-presidency/

bkelly@kosh /c/devel/tmp/cclogs/fusion
$ /c/devel/heapgraph/find_roots.py cc-edges.5660.1478724617.log 0000022920DEBC00
Parsing cc-edges.5660.1478724617.log. Done loading graph.

00000229096A6850 [Promise]
    --[mGlobal]--> 0000022920DEBC00 [nsGlobalWindow # 2147485761 inner http://fusion.net/story/36854
4/students-protest-trump-presidency/]

    Root 00000229096A6850 is a ref counted object with 1 unknown edge(s).

Till, since you recently did bug 1313049 can you look at this?

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Unfortunately just visiting the page again does not reproduce.

Comment 2

[Julien Cristau [:jcristau]]

Is anything happening with this?  There's been no reply to the needinfo in 2 months and Ben says it's not always reproducible.

Comment 3

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Based on the fact that we are unable to repro this one, I don't feel the need to track this one for 52. Please let me know if there are any concerns.

Comment 4

[Till Schneidereit [:till]]

My apologies for not responding to the needinfo. I tried to reproduce this back when the bug was filed and again today, but failed to do so. I'm not sure what can be done about this, as long as I don't have STR.