Closed Bug 1316430 Opened 8 years ago Closed 7 years ago

Intermittent layout/reftests/details-summary/mouse-click-twice-float-details.html == layout/reftests/details-summary/float-details.html | image comparison, max difference: 1, number of differing pixels: 1

Categories

(Core :: Layout, defect, P3)

Product:
Core
Component:
Layout
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox51 --- unaffected
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: neerja, Assigned: neerja)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Bug 1316430 - Add fuzzy annotation for reftests/details-summary/mouse-click-twice-float-details.html
58 bytes, text/x-review-board-request
dholbert
: review+
Details 
      No description provided.
Comment on attachment 8809160 [details]
Bug 1316430 - Add fuzzy annotation for reftests/details-summary/mouse-click-twice-float-details.html

https://reviewboard.mozilla.org/r/91796/#review91732

::: layout/reftests/details-summary/reftest.list:98
(Diff revision 1)
>  
>  # Dispatch mouse click to out-of-flow details or summary
>  == mouse-click-fixed-summary.html open-fixed-summary.html
>  == mouse-click-twice-fixed-summary.html fixed-summary.html
>  == mouse-click-float-details.html open-float-details.html
> -== mouse-click-twice-float-details.html float-details.html
> +fuzzy-if(gtkWidget,1,1) == mouse-click-twice-float-details.html float-details.html #Bug 1316430

Very small nit: we normally include a space after the begin-comment character (after the "#" in this case, in "#Bug")

This isn't a big deal, and I don't think it's worth bothering to fix it before landing here -- so I'll just go ahead and r+-and-autoland this.  But for future patches, it'd be best to include a space, for readability/consistency-with-other-code.
Attachment #8809160 - Flags: review?(dholbert) → review+
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a87aea7bdeda
Add fuzzy annotation for reftests/details-summary/mouse-click-twice-float-details.html r=dholbert
Comment on attachment 8809160 [details]
Bug 1316430 - Add fuzzy annotation for reftests/details-summary/mouse-click-twice-float-details.html

https://reviewboard.mozilla.org/r/91796/#review91740

::: layout/reftests/details-summary/reftest.list:98
(Diff revision 1)
>  
>  # Dispatch mouse click to out-of-flow details or summary
>  == mouse-click-fixed-summary.html open-fixed-summary.html
>  == mouse-click-twice-fixed-summary.html fixed-summary.html
>  == mouse-click-float-details.html open-float-details.html
> -== mouse-click-twice-float-details.html float-details.html
> +fuzzy-if(gtkWidget,1,1) == mouse-click-twice-float-details.html float-details.html #Bug 1316430

Got it. Will keep that in mind. Thanks!
(In reply to Neerja:neerja from comment #1)
> Log snippet:

Some additional context/background-info, for the record: we've only seen this in a Try run with bug 1283302's fix (which isn't surprising, since that bug's patch uncovered several other latent test-failures, which all would've become frequent intermittent oranges when bug 1283302 landed if we hadn't preemptively worked around them).

Here's a link to that Try run (which will eventually expire):
 https://treeherder.mozilla.org/#/jobs?repo=try&revision=0268d8e0c8def2152d1b9adb390c7687e8b4608c

This test failure only happened on Linux x64 opt.  Specifically, it happened in 2 out of 18 tc-R "R4" runs there.
Priority: -- → P3
Assignee: nobody → npancholi
The patch that landed here was Linux-specific, but it looks like this is actually fuzzy on all platforms. A few recent failures, linked from comment 14:
https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=40769683#L38646 (Mac)
https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=40777537#L2615 (Windows)

In both of those, the reftest screenshot shows that the topmost pixel of the "details" twiddle-arrow is a slightly different color (though only off by 1 -- it's still "max difference: 1, number of differing pixels: 1")

So we need to just update the annotation here to remove the platform restriction and mark this fuzzy(1,1).

I think MozReview makes that difficult after a patch has already landed (as one did, in comment 4).  So rather than asking neerja to post an updated patch, I'll just push a trivial followup to inbound that adjusts the annotation.
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5eebf9c35174
followup: Expand fuzzy annotation to cover all platforms, for reftest "mouse-click-twice-float-details.html". (test-only, no review)
I think we might as well close this once this followup is merged. (It's unlikely we'll invest time in figuring out why this 1px is off by 1 color-channel-value in this particular reftest case, so there's not much value in leaving this open.  Likely just a layerization issue right around when the arrow is transformed, or something like that.)

--> dropping leave-open keyword.
Keywords: leave-open
https://hg.mozilla.org/mozilla-central/rev/5eebf9c35174
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: