Convert TestSTLWrappers to a SimpleProgram

RESOLVED FIXED in Firefox 52

Status

()

Core
XPCOM
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: erahm, Assigned: erahm)

Tracking

unspecified
mozilla52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

MozReview-Commit-ID: HRmnWvxyNP
Created attachment 8809169 [details] [diff] [review]
Convert TestSTLWrappers to a SimpleProgram
Attachment #8809169 - Flags: review?(benjamin)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e660749748b7
Created attachment 8809220 [details] [diff] [review]
Convert TestSTLWrappers to a gtest

This updates to the test to a gtest deathtest as the STL wrappers expect gecko things.
Attachment #8809220 - Flags: review?(benjamin)
Attachment #8809169 - Attachment is obsolete: true
Attachment #8809169 - Flags: review?(benjamin)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=79e1691a3f92
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a02032430fc1
Created attachment 8809258 [details] [diff] [review]
Convert TestSTLWrappers to a gtest

This disables the test on Windows, which does not seem to handle gtest deathtests properly. Try run looks happy.
Attachment #8809258 - Flags: review?(benjamin)
Attachment #8809220 - Attachment is obsolete: true
Attachment #8809220 - Flags: review?(benjamin)

Comment 7

a year ago
Hrm that sucks. Worth filing a bug about getting windows deathtests working?

Updated

a year ago
Attachment #8809258 - Flags: review?(benjamin) → review+
(In reply to Benjamin Smedberg [:bsmedberg] from comment #7)
> Hrm that sucks. Worth filing a bug about getting windows deathtests working?

Yeah it's unfortunate, but we didn't actually run the test previously so it's no worse.

It would be nice to be able to do death tests on Windows, this would help with DeadlockDetector as well. I'll file a follow-up.
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce03bdac8155517a5fe17def6efb1cc6bdc9900d
Bug 1316437 - Convert TestSTLWrappers to a gtest. r=bsmedberg

Comment 10

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ce03bdac8155
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52

Updated

a year ago
Depends on: 1317451
You need to log in before you can comment on or make changes to this bug.