Convert TestSTLWrappers to a SimpleProgram

RESOLVED FIXED in Firefox 52

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: erahm, Assigned: erahm)

Tracking

unspecified
mozilla52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

MozReview-Commit-ID: HRmnWvxyNP
Created attachment 8809169 [details] [diff] [review]
Convert TestSTLWrappers to a SimpleProgram
Attachment #8809169 - Flags: review?(benjamin)
Created attachment 8809220 [details] [diff] [review]
Convert TestSTLWrappers to a gtest

This updates to the test to a gtest deathtest as the STL wrappers expect gecko things.
Attachment #8809220 - Flags: review?(benjamin)
Attachment #8809169 - Attachment is obsolete: true
Attachment #8809169 - Flags: review?(benjamin)
Created attachment 8809258 [details] [diff] [review]
Convert TestSTLWrappers to a gtest

This disables the test on Windows, which does not seem to handle gtest deathtests properly. Try run looks happy.
Attachment #8809258 - Flags: review?(benjamin)
Attachment #8809220 - Attachment is obsolete: true
Attachment #8809220 - Flags: review?(benjamin)

Comment 7

2 years ago
Hrm that sucks. Worth filing a bug about getting windows deathtests working?

Updated

2 years ago
Attachment #8809258 - Flags: review?(benjamin) → review+
(In reply to Benjamin Smedberg [:bsmedberg] from comment #7)
> Hrm that sucks. Worth filing a bug about getting windows deathtests working?

Yeah it's unfortunate, but we didn't actually run the test previously so it's no worse.

It would be nice to be able to do death tests on Windows, this would help with DeadlockDetector as well. I'll file a follow-up.

Comment 10

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ce03bdac8155
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52

Updated

2 years ago
Depends on: 1317451
You need to log in before you can comment on or make changes to this bug.