Closed
Bug 1316437
Opened 8 years ago
Closed 8 years ago
Convert TestSTLWrappers to a SimpleProgram
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
References
Details
Attachments
(1 file, 2 obsolete files)
3.96 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
MozReview-Commit-ID: HRmnWvxyNP
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8809169 -
Flags: review?(benjamin)
Assignee | ||
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e660749748b7
Assignee | ||
Comment 3•8 years ago
|
||
This updates to the test to a gtest deathtest as the STL wrappers expect gecko things.
Attachment #8809220 -
Flags: review?(benjamin)
Assignee | ||
Updated•8 years ago
|
Attachment #8809169 -
Attachment is obsolete: true
Attachment #8809169 -
Flags: review?(benjamin)
Assignee | ||
Comment 4•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=79e1691a3f92
Assignee | ||
Comment 5•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a02032430fc1
Assignee | ||
Comment 6•8 years ago
|
||
This disables the test on Windows, which does not seem to handle gtest deathtests properly. Try run looks happy.
Attachment #8809258 -
Flags: review?(benjamin)
Assignee | ||
Updated•8 years ago
|
Attachment #8809220 -
Attachment is obsolete: true
Attachment #8809220 -
Flags: review?(benjamin)
Comment 7•8 years ago
|
||
Hrm that sucks. Worth filing a bug about getting windows deathtests working?
Updated•8 years ago
|
Attachment #8809258 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 8•8 years ago
|
||
(In reply to Benjamin Smedberg [:bsmedberg] from comment #7) > Hrm that sucks. Worth filing a bug about getting windows deathtests working? Yeah it's unfortunate, but we didn't actually run the test previously so it's no worse. It would be nice to be able to do death tests on Windows, this would help with DeadlockDetector as well. I'll file a follow-up.
Assignee | ||
Comment 9•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce03bdac8155517a5fe17def6efb1cc6bdc9900d Bug 1316437 - Convert TestSTLWrappers to a gtest. r=bsmedberg
Comment 10•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ce03bdac8155
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•