1316437 - Convert TestSTLWrappers to a SimpleProgram

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Eric Rahm [:erahm]]

MozReview-Commit-ID: HRmnWvxyNP

Comment 1

[Eric Rahm [:erahm]]

Attachment: Convert TestSTLWrappers to a SimpleProgram

Comment 2

[Eric Rahm [:erahm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e660749748b7

Comment 3

[Eric Rahm [:erahm]]

Attachment: Convert TestSTLWrappers to a gtest

This updates to the test to a gtest deathtest as the STL wrappers expect gecko things.

Comment 4

[Eric Rahm [:erahm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=79e1691a3f92

Comment 5

[Eric Rahm [:erahm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a02032430fc1

Comment 6

[Eric Rahm [:erahm]]

Attachment: Convert TestSTLWrappers to a gtest

This disables the test on Windows, which does not seem to handle gtest deathtests properly. Try run looks happy.

Comment 7

[Benjamin Smedberg]

Hrm that sucks. Worth filing a bug about getting windows deathtests working?

Comment 8

[Eric Rahm [:erahm]]

(In reply to Benjamin Smedberg [:bsmedberg] from comment #7)
> Hrm that sucks. Worth filing a bug about getting windows deathtests working?

Yeah it's unfortunate, but we didn't actually run the test previously so it's no worse.

It would be nice to be able to do death tests on Windows, this would help with DeadlockDetector as well. I'll file a follow-up.

Comment 9

[Eric Rahm [:erahm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ce03bdac8155517a5fe17def6efb1cc6bdc9900d
Bug 1316437 - Convert TestSTLWrappers to a gtest. r=bsmedberg

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ce03bdac8155