Created attachment 8809169 [details] [diff] [review] Convert TestSTLWrappers to a SimpleProgram
Created attachment 8809220 [details] [diff] [review] Convert TestSTLWrappers to a gtest This updates to the test to a gtest deathtest as the STL wrappers expect gecko things.
Created attachment 8809258 [details] [diff] [review] Convert TestSTLWrappers to a gtest This disables the test on Windows, which does not seem to handle gtest deathtests properly. Try run looks happy.
Attachment #8809258 - Flags: review?(benjamin)
Hrm that sucks. Worth filing a bug about getting windows deathtests working?
(In reply to Benjamin Smedberg [:bsmedberg] from comment #7) > Hrm that sucks. Worth filing a bug about getting windows deathtests working? Yeah it's unfortunate, but we didn't actually run the test previously so it's no worse. It would be nice to be able to do death tests on Windows, this would help with DeadlockDetector as well. I'll file a follow-up.
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce03bdac8155517a5fe17def6efb1cc6bdc9900d Bug 1316437 - Convert TestSTLWrappers to a gtest. r=bsmedberg
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.