Closed Bug 1316437 Opened 5 years ago Closed 5 years ago

Convert TestSTLWrappers to a SimpleProgram

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: erahm, Assigned: erahm)

References

Details

Attachments

(1 file, 2 obsolete files)

MozReview-Commit-ID: HRmnWvxyNP
Attachment #8809169 - Flags: review?(benjamin)
This updates to the test to a gtest deathtest as the STL wrappers expect gecko things.
Attachment #8809220 - Flags: review?(benjamin)
Attachment #8809169 - Attachment is obsolete: true
Attachment #8809169 - Flags: review?(benjamin)
This disables the test on Windows, which does not seem to handle gtest deathtests properly. Try run looks happy.
Attachment #8809258 - Flags: review?(benjamin)
Attachment #8809220 - Attachment is obsolete: true
Attachment #8809220 - Flags: review?(benjamin)
Hrm that sucks. Worth filing a bug about getting windows deathtests working?
Attachment #8809258 - Flags: review?(benjamin) → review+
(In reply to Benjamin Smedberg [:bsmedberg] from comment #7)
> Hrm that sucks. Worth filing a bug about getting windows deathtests working?

Yeah it's unfortunate, but we didn't actually run the test previously so it's no worse.

It would be nice to be able to do death tests on Windows, this would help with DeadlockDetector as well. I'll file a follow-up.
https://hg.mozilla.org/mozilla-central/rev/ce03bdac8155
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Depends on: 1317451
You need to log in before you can comment on or make changes to this bug.