Closed Bug 1316479 Opened 3 years ago Closed 3 years ago

Move CrossProcessCompositorBridgeParent to its own file

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: rhunt, Assigned: rhunt)

Details

Attachments

(1 file, 1 obsolete file)

CrossProcessCompositorBridgeParent should really be in its own file.
Attached patch move-cpcbp.patch (obsolete) — Splinter Review
Attachment #8809249 - Flags: review?(dvander)
While I'm in favor of this, I'd prefer doing an |hg cp| to copy CompositorBridgeParent.cpp to the new .cpp file, and then deleting the unnecessary chunks out of both cpp files. That way |hg blame| will still work through this patch.
Yes that'd be much better. Didn't know that was an option.
Attached patch move-cpcbp.patchSplinter Review
Use hg copy instead
Attachment #8809249 - Attachment is obsolete: true
Attachment #8809249 - Flags: review?(dvander)
Attachment #8809487 - Flags: review?(dvander)
Comment on attachment 8809487 [details] [diff] [review]
move-cpcbp.patch

The diff for this is pretty hard to read -- assuming this is just code motion, though, r=me
Attachment #8809487 - Flags: review?(dvander) → review+
Pushed by rhunt@eqrion.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c50d0c4cf00
Move CrossProcessCompositorBridgeParent to its own file. r=dvander
https://hg.mozilla.org/mozilla-central/rev/5c50d0c4cf00
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.