1316523 - Labels in Firefox menu look pixelated

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Sebastian Zartner [:sebo]]

Attachment: Comparison between 50.0 and 51.0a2

In Firefox Developer Edition 51.0a2 (2016-11-09) (64-bit) the labels within the Firefox menu look pixelated on Windows 7 (64-bit).

A comparing screenshot between Beta 50 and DevEdition 51.0a2 (each using a new profile) is attached.

Sebastian

Comment 1

[Sebastian Zartner [:sebo]]

According to mozregression-gui this is caused by:

Bug 1296665: gfxBlur should attempt to create a box shadow for the correct type of DrawTarget. r=mchang

MozReview-Commit-ID: 5J3GwKya83w

Sebastian

Comment 2

[Sebastian Zartner [:sebo]]

"pixelated" is probably not the right word. Maybe someone can find a better word for this.

Sebastian

Comment 3

[Gerry Chang [:gchang]]

Hi :bas.schouten,
Per comment #1, can you help take a look at this?

Comment 4

[Bas Schouten (:bas.schouten)]

This is grayscale vs. non grayscale AA and should have been mostly fixed. Although there's some indication in some cases Layout is telling us the background may be transparent and we shouldn't use subpixel AA. Where we actually could.

Comment 5

[Lee Salzman [:lsalzman]]

(In reply to Bas Schouten (:bas.schouten) from comment #4)
> This is grayscale vs. non grayscale AA and should have been mostly fixed.
> Although there's some indication in some cases Layout is telling us the
> background may be transparent and we shouldn't use subpixel AA. Where we
> actually could.

"mostly fixed" how and where? Is there a relevant bug number regarding this?

Comment 6

[Lee Salzman [:lsalzman]]

Can you please test this with nightly and see if this has already been fixed?

cf: bug 1303570 and bug 1306670

Comment 7

[Sebastian Zartner [:sebo]]

I tried this right now on Windows 10 with today's Nightly and didn't experience the issue. Though I still need to try it on the Windows 7 machine where I originally saw the bug. I'll let you know tomorrow.

Sebastian

Comment 8

[Sebastian Zartner [:sebo]]

Attachment: Display in 53.0a1

It looks definitely way better now. See the attached screenshot of Nightly 2016-11-22. Only a few characters like the "t" in "Print" still look a little bit different, though I guess most people won't notice that.

Sebastian

Comment 9

[Milan Sreckovic [:milan] (needinfo for best results)]

Let's reopen if it turns out that bug 1303570 and bug 1306670 patches didn't fix this "enough", in the meantime, closing it.