Closed Bug 1316524 Opened 3 years ago Closed 3 years ago

"media.wmf.skip-blacklist" will be ignored by GPU decoding process, when blacklisting D3D

Categories

(Core :: Audio/Video: Playback, defect)

49 Branch
All
Windows
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: gerald, Assigned: gerald)

References

Details

Attachments

(1 file)

Jean-Yves noticed that the patch in bug 1313343 (to account for "media.wmf.skip-blacklist" before applying D3D DLL blacklists) uses MediaPrefs, which are not accessible from the GPU decoding process.

We should probably use the same gfxVars, which is used to forward the blacklists prefs:
https://dxr.mozilla.org/mozilla-central/rev/336759fad4621dfcd0a3293840edbed67018accd/gfx/thebes/gfxPlatform.cpp#620
Maybe the easiest is to do so when the blacklist parameter is constructed.
Comment on attachment 8809645 [details]
Bug 1316524 - Use 'media.wmf.skip-blacklist' to set some gfxVars -

https://reviewboard.mozilla.org/r/92184/#review92182
Attachment #8809645 - Flags: review?(matt.woodrow) → review+
Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/680467d99ed6
Use 'media.wmf.skip-blacklist' to set some gfxVars - r=mattwoodrow
https://hg.mozilla.org/mozilla-central/rev/680467d99ed6
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.