Closed Bug 1316543 Opened 3 years ago Closed 3 years ago

Fix the calculation of VideoSink::mVideoFrameEndTime

Categories

(Core :: Audio/Video: Playback, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox50 --- affected
firefox51 --- fixed
firefox52 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(1 file)

http://searchfox.org/mozilla-central/rev/008fdd93290c83325de6629a1ae48dc2afaed868/dom/media/mediasink/VideoSink.cpp#427

// The presentation end time of the last video frame displayed is either
// the end time of the current frame, or if we dropped all frames in the
// queue, the end time of the last frame we removed from the queue.

To match the comment, lastDisplayedFrameEndTime should be updated no matter the last frame is sent to the compositor or not.

This fixes a bug where currentTime stops progressing when decoding is slow on a video only file because all video frames are dropped and mVideoFrameEndTime is not updated at all.
Assignee: nobody → jwwang
Blocks: 1286129
Priority: -- → P3
Attachment #8809316 - Flags: review?(cpearce)
Comment on attachment 8809316 [details]
Bug 1316543 - Fix the calculation of VideoSink::mVideoFrameEndTime.

https://reviewboard.mozilla.org/r/91910/#review92168
Attachment #8809316 - Flags: review?(cpearce) → review+
Thanks!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8b045b23dd94
Fix the calculation of VideoSink::mVideoFrameEndTime. r=cpearce
https://hg.mozilla.org/mozilla-central/rev/8b045b23dd94
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
In https://bugzilla.mozilla.org/show_bug.cgi?id=1316571#c14 jya asked if we could uplift this to I guess Aurora and stage it for potential 50 dot releases and 50.1. I'm echoing that request here :)
Flags: needinfo?(jwwang)
Comment on attachment 8809316 [details]
Bug 1316543 - Fix the calculation of VideoSink::mVideoFrameEndTime.

Approval Request Comment
[Feature/regressing bug #]:1258870
[User impact if declined]:currentTime might stop progressing when playing a video only file.
[Describe test coverage new/current, TreeHerder]:TreeHerder
[Risks and why]: Low. The change is fairly simple.
[String/UUID change made/needed]:none
Flags: needinfo?(jwwang)
Attachment #8809316 - Flags: approval-mozilla-beta?
Comment on attachment 8809316 [details]
Bug 1316543 - Fix the calculation of VideoSink::mVideoFrameEndTime.

Fix an issue related to playing a video. Beta51+. Should be in 51 beta 2.
Attachment #8809316 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.