1316544 - [WebGL2 conformance test] Pass 2/conformance2/textures/misc/copy-texture-image-webgl-specific.html

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Michael Leu[:Lenzak](UTC+8)]

We misjudge testcase "copytexsubimage3d_valid_operation_diff_layer" as a copy feed back loop, so we need some kind of depth checking to correct this failure.

https://www.khronos.org/registry/webgl/sdk/tests/conformance2/textures/misc/copy-texture-image-webgl-specific.html?webglVersion=2&quiet=0

Comment 1

[Michael Leu[:Lenzak](UTC+8)]

Attachment: Fix conformance test fail in texture image webgl specific

Comment 2

[Ethan Lin[:ethlin]]

Comment on attachment 8809318 [details] [diff] [review]
Fix conformance test fail in texture image webgl specific

:jgilbert should know more about this.

Comment 3

[Michael Leu[:Lenzak](UTC+8)]

Attachment: Fix conformance test fail in texture image webgl specific r=jgilbert

Change uint32_t to GLint to prevent compile time error caused by comparing signed and unsigned integer

Comment 4

[Michael Leu[:Lenzak](UTC+8)]

Here is try result
https://treeherder.mozilla.org/#/jobs?repo=try&revision=005dda24ce2886a30818ef8e76d39738e186c7f6&selectedJob=31381800

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9dc2ef01f861
Fix conformance test fail in texture-image-webgl-specific r=jgilbert

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9dc2ef01f861

Comment 7

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8812066 [details] [diff] [review]
Fix conformance test fail in texture image webgl specific r=jgilbert

Review of attachment 8812066 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLTextureUpload.cpp
@@ +1926,4 @@
>          MOZ_ASSERT(attach);
>  
>          if (attach->Texture() == this &&
> +            attach->Layer() == layer &&

Layer() should be returning uint32_t.

Comment 8

[areya]

https://hg.mozilla.org/mozilla-central/rev/9dc2ef01f861

Comment 9

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8812066 [details] [diff] [review]
Fix conformance test fail in texture image webgl specific r=jgilbert

Approval Request Comment
[Feature/Bug causing the regression]: webgl2
[User impact if declined]:
[Is this code covered by automated tests?]:
[Has the fix been verified in Nightly?]:
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]:
[Why is the change risky/not risky?]:
[String changes made/needed]:

Comment 10

[Gerry Chang [:gchang]]

Comment on attachment 8812066 [details] [diff] [review]
Fix conformance test fail in texture image webgl specific r=jgilbert

WebGL2 related patch. Beta51+ & Aurora52+. Should be in 51 beta 8.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1977f2887f5c

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5b85d13c47da