Closed
Bug 1316614
Opened 8 years ago
Closed 8 years ago
Wasm: Implement lookahead in the iterator
Categories
(Core :: JavaScript Engine: JIT, defect, P1)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: lth, Assigned: lth)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.88 KB,
patch
|
sunfish
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1286816 +++ The patches that implement boolean optimization for control in the baseline compiler (bug 1286816) will want to examine the next token in the token stream when processing a comparison opcode, to see if the boolean value will be consumed immediately.
|
Assignee | |
Comment 1•8 years ago
|
||
Implements an infallible peekOp() that can be used whereever readOp() is legal. I will need this to implement the optimization in bug 1286816 without adding overhead to the baseline compiler's decoding loop.
Attachment #8809445 -
Attachment is obsolete: true
Attachment #8812123 -
Flags: review?(sunfish)
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8812123 [details] [diff] [review] bug1316614-op-lookahead.patch Review of attachment 8812123 [details] [diff] [review]: ----------------------------------------------------------------- Sounds good to me.
Attachment #8812123 -
Flags: review?(sunfish) → review+
|
|
Assignee | |
Comment 4•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f4b4df249c38cf91484629eb3d59f5482f6e377c Bug 1316614 - add Op lookahead to wasm iterator. r=sunfish
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f4b4df249c38
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•