Wasm: Implement lookahead in the iterator

RESOLVED FIXED in Firefox 53

Status

()

P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: lth, Assigned: lth)

Tracking

unspecified
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 years ago
Created attachment 8809445 [details] [diff] [review]
expr-lookahead.patch

+++ This bug was initially created as a clone of Bug #1286816 +++

The patches that implement boolean optimization for control in the baseline compiler (bug 1286816) will want to examine the next token in the token stream when processing a comparison opcode, to see if the boolean value will be consumed immediately.
(Assignee)

Comment 1

2 years ago
Created attachment 8812123 [details] [diff] [review]
bug1316614-op-lookahead.patch

Implements an infallible peekOp() that can be used whereever readOp() is legal.  I will need this to implement the optimization in bug 1286816 without adding overhead to the baseline compiler's decoding loop.
Attachment #8809445 - Attachment is obsolete: true
Attachment #8812123 - Flags: review?(sunfish)
(Assignee)

Comment 2

2 years ago
P1 to avoid priority inversion.
Priority: P3 → P1
Comment on attachment 8812123 [details] [diff] [review]
bug1316614-op-lookahead.patch

Review of attachment 8812123 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds good to me.
Attachment #8812123 - Flags: review?(sunfish) → review+

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f4b4df249c38
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.