Closed Bug 1316625 Opened 3 years ago Closed 3 years ago

Baldr: tidy up WasmBinary*.h

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: luke, Assigned: luke)

References

Details

Attachments

(1 file)

Attached patch rearrangeSplinter Review
This just moves things around so the headers are a bit more coherent.
Attachment #8809461 - Flags: review?(bbouvier)
Comment on attachment 8809461 [details] [diff] [review]
rearrange

Review of attachment 8809461 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

::: js/src/wasm/WasmBinaryConstants.h
@@ +38,5 @@
> +    Export                               = 7,
> +    Start                                = 8,
> +    Elem                                 = 9,
> +    Code                                 = 10,
> +    Data                                 = 11

Aligning with the NameSectionName equal sign below looks a bit weird to me...
Attachment #8809461 - Flags: review?(bbouvier) → review+
Blocks: 1316651
Pushed by lwagner@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b0a99027126
Baldr: tidy up WasmBinary*.h (r=bbouvier)
https://hg.mozilla.org/mozilla-central/rev/1b0a99027126
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Depends on: 1331939
You need to log in before you can comment on or make changes to this bug.