Closed Bug 1316635 Opened 3 years ago Closed 3 years ago

wasm: Factor out section decoding

Categories

(Core :: JavaScript Engine: JIT, defect, P2)

defect

Tracking

()

RESOLVED FIXED
Tracking Status
firefox52 --- affected

People

(Reporter: bbouvier, Assigned: bbouvier)

References

Details

Attachments

(6 files)

No description provided.
Priority: -- → P2
Comment on attachment 8809468 [details]
Bug 1316635: Factor out DecodeTypeSection;

https://reviewboard.mozilla.org/r/92044/#review92146
Attachment #8809468 - Flags: review?(luke) → review+
Comment on attachment 8809469 [details]
Bug 1316635: Factor out DecodeImportsSection;

https://reviewboard.mozilla.org/r/92046/#review92150
Attachment #8809469 - Flags: review?(luke) → review+
Comment on attachment 8809470 [details]
Bug 1316635: Factor out DecodeFunctionSection;

https://reviewboard.mozilla.org/r/92048/#review92152
Attachment #8809470 - Flags: review?(luke) → review+
Comment on attachment 8809471 [details]
Bug 1316635: Order declarations in WasmBinaryFormat.h;

https://reviewboard.mozilla.org/r/92050/#review92154
Attachment #8809471 - Flags: review?(luke) → review+
Comment on attachment 8809472 [details]
Bug 1316635: Remove AstDecode from AstDecodeGenerate{Ref,Name};

https://reviewboard.mozilla.org/r/92052/#review92156
Attachment #8809472 - Flags: review?(luke) → review+
Comment on attachment 8809473 [details]
Bug 1316635: Remove dead oldElems arguments;

https://reviewboard.mozilla.org/r/92054/#review92158

yay, great work on these!
Attachment #8809473 - Flags: review?(luke) → review+
Pushed by lwagner@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e33f5dd90abe
Factor out DecodeTypeSection; r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/5227163b9dad
Factor out DecodeImportsSection; r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/aed62b2e0a8a
Factor out DecodeFunctionSection; r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ad7c2178c63
Order declarations in WasmBinaryFormat.h; r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/aa7d53db2b20
Remove AstDecode from AstDecodeGenerate{Ref,Name}; r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/f3e9a9c4566f
Remove dead oldElems arguments; r=luke
Keywords: leave-open
You might want to open a new bug if you want to land extra bits to this bug. It is easier to follow if patches are specific to the same branch.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.