Closed Bug 1316651 Opened 3 years ago Closed 3 years ago

Baldr: don't assign unchecked decoded integers to enums

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: luke, Assigned: luke)

References

Details

Attachments

(2 files, 1 obsolete file)

Attached patch typier-decoding (obsolete) — Splinter Review
This uses the type system to maintain the unchecked/checked separation and avoids the need for fixed representation types on the enums.
Attachment #8809495 - Flags: review?(sunfish)
Attached patch 2. rename-opSplinter Review
One more big trivial renaming before the 52 branch: now that wasm's totally not an AST, this patch renames Expr to Op, ExprIter to OpIter, and a bunch of variable/parameter names accordingly.
Attachment #8809622 - Flags: review?(sunfish)
rebased
Attachment #8809495 - Attachment is obsolete: true
Attachment #8809495 - Flags: review?(sunfish)
Attachment #8809660 - Flags: review?(sunfish)
Attachment #8809622 - Attachment description: rename-op → 2. rename-op
Comment on attachment 8809622 [details] [diff] [review]
2. rename-op

Review of attachment 8809622 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds reasonable.
Attachment #8809622 - Flags: review?(sunfish) → review+
Comment on attachment 8809660 [details] [diff] [review]
1. typier-decoding

Review of attachment 8809660 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Attachment #8809660 - Flags: review?(sunfish) → review+
Pushed by lwagner@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8a0300ec29c9
Baldr: change decoding of enumerated values (r=sunfish)
https://hg.mozilla.org/integration/mozilla-inbound/rev/52a2f468a31c
Baldr: rename Expr to Op (r=sunfish)
https://hg.mozilla.org/mozilla-central/rev/8a0300ec29c9
https://hg.mozilla.org/mozilla-central/rev/52a2f468a31c
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.