Closed Bug 1316661 Opened 3 years ago Closed 3 years ago

Eliminate calls to IsCallerChrome in dom/html code

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(6 files)

No description provided.
Depends on: 1316758
Depends on: 1316951
Depends on: 1317367
The only nsGenericHTMLElement::GetEditor callers are
HTMLInputElement::GetEditor/HTMLTextareaElement::GetEditor (the XPCOM-y
versions), which are only called from C++ and only from two places: a11y code,
which forces itself to look like system, and typeaheadfind, which would break
badly if it could not get an editor.  So that security check simply shouldn't
exist.

The script API doesn't call down into here _and_ is [ChromeOnly] in the webidl
already.
Attachment #8810455 - Flags: review?(bugs)
The WebIDL caller of SetUserInput is [ChromeOnly] and the other callers are all C++ code that should be able to set the value.
Attachment #8810457 - Flags: review?(bugs)
Attachment #8810453 - Flags: review?(bugs) → review+
Attachment #8810457 - Flags: review?(bugs) → review+
Attachment #8810458 - Flags: review?(bugs) → review+
Attachment #8810455 - Flags: review?(bugs) → review+
Attachment #8810456 - Flags: review?(bugs) → review+
Comment on attachment 8810454 [details] [diff] [review]
part 2.  Eliminate IsCallerChrome callers in HTMLDocument

>-    if (NS_FAILED(rv)) {
>+    // Note that it doesn't matter what CallerType we pass, because the caleee
callee
Attachment #8810454 - Flags: review?(bugs) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/40f2ef965fde
part 1.  Eliminate IsCallerChrome callers in HTMLCanvasElement code.  r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/9279b5e62d23
part 2.  Eliminate IsCallerChrome callers in HTMLDocument.  r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/52620710ec9f
part 3.  Eliminate IsCallerChrome callers in nsGenericHTMLElement.  r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/fe7461fb4426
part 4.  Eliminate IsCallerChrome callers in HTMLMenuElement.  r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d7cf1d3124c
part 5.  Eliminate IsCallerChrome caller in HTMLTextareaElement.  r=smaug
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7d6c3fc9d6e4
part 6.  Get rid of nsIObjectLoadingContent.hasRunningPlugin, since it's unused.  r=smaug
You need to log in before you can comment on or make changes to this bug.