Closed Bug 1316667 Opened 3 years ago Closed 3 years ago

unable to run |mach web-platform-tests ...| on windows 10

Categories

(Testing :: web-platform-tests, defect)

defect
Not set

Tracking

(firefox52 fixed)

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: jmaher, Unassigned)

Details

Attachments

(1 file)

I run a lot of other tests via mach command on windows test inside of the mozilla-build environment, but for web-platform-tests, I fail to have success:

elvis@JMAHER-WIN10 ~/mozilla-inbound
$ ./mach web-platform-tests testing/web-platform/tests/html/semantics/embedded-content/the-img-element/img.complete
Error running mach:

    ['web-platform-tests', 'testing/web-platform/tests/html/semantics/embedded-content/the-img-element/img.complete']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

Exception: Binary expected at c:/Users/elvis/mozilla-inbound/obj-i686-pc-mingw32\dist\bin\.exe does not exist.

  File "c:\Users\elvis\mozilla-inbound\testing/web-platform/mach_commands.py", line 314, in run_web_platform_tests
    return wpt_runner.run_tests(**params)
  File "c:\Users\elvis\mozilla-inbound\testing/web-platform/mach_commands.py", line 72, in run_tests
    self.setup_kwargs(kwargs)
  File "c:\Users\elvis\mozilla-inbound\testing/web-platform/mach_commands.py", line 48, in setup_kwargs
    kwargs["stackfix_dir"] = self.get_binary_path("")
  File "c:\Users\elvis\mozilla-inbound\python/mozbuild\mozbuild\base.py", line 336, in get_binary_path
    raise Exception('Binary expected at %s does not exist.' % path)

elvis@JMAHER-WIN10 ~/mozilla-inbound




so the specific error:
Exception: Binary expected at c:/Users/elvis/mozilla-inbound/obj-i686-pc-mingw32\dist\bin\.exe does not exist.

is missing firefox.exe as the project name...I wonder why this works for |mach test| and |mach mochitest|
a hack locally which works:
--- a/testing/web-platform/mach_commands.py
+++ b/testing/web-platform/mach_commands.py
@@ -40,17 +40,18 @@ class WebPlatformTestsRunner(MozbuildObj

         if kwargs["binary"] is None:
             kwargs["binary"] = self.get_binary_path('app')

         if kwargs["prefs_root"] is None:
             kwargs["prefs_root"] = os.path.join(self.topobjdir, '_tests', 'web-platform', "prefs")

         if kwargs["stackfix_dir"] is None:
-            kwargs["stackfix_dir"] = self.get_binary_path("")
+#            kwargs["stackfix_dir"] = self.get_binary_path("")
+            kwargs["stackfix_dir"] = os.path.split(self.get_binary_path("certutil"))[0]

         if kwargs["certutil_binary"] is None:
             kwargs["certutil_binary"] = self.get_binary_path('certutil')

         here = os.path.split(__file__)[0]

         if kwargs["ssl_type"] in (None, "pregenerated"):
             if kwargs["ca_cert_path"] is None:
Comment on attachment 8809891 [details]
Bug 1316667 - Use a path that exists when resolving stackfix dir,

https://reviewboard.mozilla.org/r/92384/#review92446

this looks good, thanks for making it
Attachment #8809891 - Flags: review?(jmaher) → review+
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/autoland/rev/7444086c2a4d
Use a path that exists when resolving stackfix dir, r=jmaher
https://hg.mozilla.org/mozilla-central/rev/7444086c2a4d
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.