1316700 - make developer-toolbar eslint-clean

Status: RESOLVED FIXED

(DevTools :: Framework, defect, P3)

Description

[Tom Tromey :tromey]

I happened to notice an eslint exclusion for developer-toolbar.js.
This bug is for converting it to be eslint-clean.

Comment 1

[Tom Tromey :tromey]

Most of the patch is obvious but I converted |show| to use Task.spawn in order
to avoid an eslint error about too many nested functions.

Comment 2

[Tom Tromey :tromey]

Attachment: Bug 1316700 - make developer-toolbar.js eslint-clean;

Review commit: https://reviewboard.mozilla.org/r/92124/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92124/

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8809575 [details]
Bug 1316700 - make developer-toolbar.js eslint-clean;

https://reviewboard.mozilla.org/r/92124/#review92120

Thanks, looks like a great cleanup, especially with all the indentation cleanup!

::: devtools/client/shared/developer-toolbar.js:427
(Diff revision 1)
>      return this._showPromise;
>    }
>  
> +  this._showPromise = Task.spawn((function* () {
> -  // hide() is async, so ensure we don't need to wait for hide() to finish
> +    // hide() is async, so ensure we don't need to wait for hide() to finish
> -  var waitPromise = this._hidePromise || promise.resolve();
> +    yield this._hidePromise || promise.resolve();

Hmm, what's the precedence of `yield` vs. `||`?

Probably the following is easier to follow:

```
if (this._hidePromise) {
  yield this._hidePromise;
}
```

Comment 4

[Tom Tromey :tromey]

Comment on attachment 8809575 [details]
Bug 1316700 - make developer-toolbar.js eslint-clean;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92124/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9d5f467f78d
make developer-toolbar.js eslint-clean; r=jryans

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a9d5f467f78d