1316727 - Creating containers without a name can get confusing

Status: VERIFIED FIXED

(Core :: DOM: Security, defect, P5)

Description

[Peter deHaan [:pdehaan]]

Go to about:preferences#containers in Nightly

1. Add a new container and set a space as the container name.
2. Click "Done".
3. Select "File" > "New Container Tab" from the main menu


### Actual results:
There is an empty option in the menu where the unnamed container is.

### Expected results:
Maybe not allow unnamed containers, and we do a trim() on the container name before allowing the user to create a new container.

Comment 1

[Peter deHaan [:pdehaan]]

Similarly, I have three nameless containers, separated only by icon+colors, but the File > New Container Tab menu doesn't display the icons, so I just have 3 empty slots.

Comment 2

[Kamil Jozwiak [:kjozwiak]]

(In reply to Peter deHaan [:pdehaan] from comment #1)
> Similarly, I have three nameless containers, separated only by icon+colors,
> but the File > New Container Tab menu doesn't display the icons, so I just
> have 3 empty slots.

If you're using macOS, the missing icons are because of bug#1316919. If you're not using macOS, could you please let me know which OS you're seeing the missing icons under? We might have another regression somewhere :/

I agree that we shouldn't give users the ability to create "empty" containers with nothing but spaces. It's definitely not good UX.

Comment 3

[Andrea Marchesini [:baku]]

We can probably use a similar approach to what we are doing in testpilot: Container<number> if the name is not set.

Comment 4

[Firefox Bug Husbandry Bot]

Bulk change per https://bugzilla.mozilla.org/show_bug.cgi?id=1401020

Comment 5

[Danny Colin [:sdk]]

Attachment: Bug 1316727 - Ensure we cannot create a containers with no name r?mconley

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e5bd1922ed2
Ensure we cannot create a containers with no name r=mconley

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/4e5bd1922ed2

Comment 8

[Ardelean Oana, Desktop QA [:oardelean]]

Reproducible on a 2023-01-15 Nightly build on Ubuntu 22.
Verified as fixed on Nightly 112.0a1(build ID: 20230301225323) on Ubuntu 22, Windows 11, macOS 12.