Closed
Bug 1316738
Opened 9 years ago
Closed 9 years ago
Remove XPCOM test TestInterfaceInfo
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
References
Details
Attachments
(1 file)
|
5.63 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
This removes a GeckoSimpleProgram that is neither built nor run.
MozReview-Commit-ID: 5ERreh9Gksw
|
Assignee | |
Comment 1•9 years ago
|
||
I think we could get away with leaving this around since it's not built, but it seems cleaner to get rid of it. Converting to a gtest would also present some trickiness as it depends on command line arguments.
Attachment #8809607 -
Flags: review?(nfroyd)
|
|
Assignee | |
Comment 2•9 years ago
|
||
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8809607 [details] [diff] [review]
Remove XPCOM test TestInterfaceInfo
Review of attachment 8809607 [details] [diff] [review]:
-----------------------------------------------------------------
Seems useful, but trying to remove the dependency on command-line arguments probably isn't worth it.
Attachment #8809607 -
Flags: review?(nfroyd) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/47c1673055172688a6e596115c01a4e978f41118
Bug 1316738 - Remove XPCOM test TestInterfaceInfo. r=froydnj
|
||
Comment 5•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•