1316747 - Add confirmation prompt before deleting active containers tabs?

Status: RESOLVED DUPLICATE of bug 1316740

(Core :: DOM: Security, defect)

Description

[Peter deHaan [:pdehaan]]

1. Go to about:preferences#containers
2. Add a couple new tba containers.
3. Open a few links in the new tab containers.
4. Go back to about:preferences#containers.
5. Delete the container tabs by clicking on the [Remove] buttons next to the container names.

### Actual results:
Tab containers are deleted without any sort of confirmation.

### Expected results:
Not sure if we should add a "Are you sure?" confirmation, although it isn't a huge catastrophe if you delete the container.

But if you go to about:preferences#privacy and deselect the "Enable Container Tabs" checkbox, you _do_ see a "Close All Container Tabs? If you disable Container Tabs now, 18 container tabs will be closed. Are you sure you want to disable Container Tabs? [Keep enabled] [Close 18 Container Tabs]" dialog.

Not sure if it'd make sense to allow users to blindly delete a container tab without a confirmation if there are zero open tabs, but give them a challenge dialog saying "If you delete 'Banking' Container Tabs now, 4 container tabs will be closed. Are you sure?" style confirmation.

Comment 1

[Kamil Jozwiak [:kjozwiak]]

We can probably dupe this to bug#1316740 as they're essentially the same thing. As per bug#1316740comment#2, the default behaviour that was supposed to be implemented in bug#1267916 was to prompt the user whenever they're removing a container that's still being used/opened.

Thanks for all the bug report Peter :)