Closed
Bug 1316749
Opened 8 years ago
Closed 7 years ago
./mach taskgraph should retry index look-ups when optimizing docker-image builds
Categories
(Firefox Build System :: Task Configuration, task)
Firefox Build System
Task Configuration
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jonasfj, Assigned: dustin)
References
Details
Attachments
(1 file)
There is no retries here: https://dxr.mozilla.org/mozilla-central/rev/336759fad4621dfcd0a3293840edbed67018accd/taskcluster/taskgraph/task/docker_image.py#128-131
|
Assignee | |
Comment 1•8 years ago
|
||
Probably best to use the taskclusterProxy for that.
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → dustin
| Comment hidden (mozreview-request) |
|
Reporter | |
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8822883 [details] Bug 1316749: use taskcluster-proxy to hit index for docker image optimization; https://reviewboard.mozilla.org/r/101654/#review102430 I would still prefer retries client side. so that this code can run outside docker-worker. Even if we rarely run it outside docker-worker it's so nice for debug-ability.
Attachment #8822883 -
Flags: review?(jopsen) → review+
Pushed by dmitchell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bb576b8ab4fa use taskcluster-proxy to hit index for docker image optimization; r=jonasfj
|
|
Assignee | |
Comment 5•7 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8822883 [details] Bug 1316749: use taskcluster-proxy to hit index for docker image optimization; https://reviewboard.mozilla.org/r/101654/#review102430 Oh, ugh, now that you mention it -- this won't work, because the code can't run outside of docker -- on a desktop, for example. It should be conditioned on $TASK_ID being set, instead. Too bad I just sent it to autoland.
|
|
Assignee | |
Updated•7 years ago
|
Keywords: leave-open
|
||
Comment 6•7 years ago
|
||
backed out on request from dustin
Backout by cbook@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/675a08c70944 Backed out changeset bb576b8ab4fa on request from dustin
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8822883 -
Flags: review+ → review?(jopsen)
|
|
Reporter | |
Comment 10•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8822883 [details] Bug 1316749: use taskcluster-proxy to hit index for docker image optimization; https://reviewboard.mozilla.org/r/101654/#review103532 Okay, that's super fancy!
Attachment #8822883 -
Flags: review?(jopsen) → review+
|
||
Comment 11•7 years ago
|
||
Pushed by dmitchell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1f38938f4e9b use taskcluster-proxy to hit index for docker image optimization; r=jonasfj
| Comment hidden (mozreview-request) |
|
|
||
Comment 13•7 years ago
|
||
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/autoland/rev/e3d4bca8197c Backed out changeset 1f38938f4e9b for flake8 lint error. r=backout https://hg.mozilla.org/integration/autoland/rev/88f2a76d67dd use taskcluster-proxy to hit index for docker image optimization; r=jonasfj
|
||
Comment 14•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/88f2a76d67dd
|
|
Reporter | |
Comment 15•7 years ago
|
||
Using tc proxy fixes this.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
||
Comment 16•6 years ago
|
||
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
|
||
Updated•6 years ago
|
Product: TaskCluster → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•