Closed Bug 1316770 Opened 3 years ago Closed 3 years ago
.html == writing-mode/1089388-1-ref .html | image comparison, max difference: 208, number of differing pixels: 3
Filed by: philringnalda [at] gmail.com https://treeherder.mozilla.org/logviewer.html#?job_id=38985419&repo=mozilla-inbound https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-macosx64-debug/1478804299/mozilla-inbound_yosemite_r7-debug_test-reftest-e10s-bm106-tests1-macosx-build386.txt.gz https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-macosx64-debug/1478804299/mozilla-inbound_yosemite_r7-debug_test-reftest-e10s-bm106-tests1-macosx-build386.txt.gz&only_show_unexpected=1
3 years ago
Component: Layout → Layout: Block and Inline
Is it okay to avoid the on-going intermittent failures here with fuzzy(), or is more investigation required? Recent failures look like: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/FXCLEh-bTVaKekjh4NXG7Q/runs/0/artifacts/public/logs/live_backing.log
I think we may be able to fix this by adding text-rendering:optimizeLegibility to the testcases, to ensure we get actual glyph bounds for invalidation/painting purposes (instead of potentially using approximate bounds based on advance width and font height).
Could we give this a try, before resorting to adding fuzz annotations? I pushed it to tryserver (https://treeherder.mozilla.org/#/jobs?repo=try&revision=059a6cf35dcac2cb713a65745ad1477a2bf42d25) and so far haven't seen a failure there, though this is rare enough that it's hard to really be confident.
Attachment #8893769 - Flags: review?(gbrown)
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Comment on attachment 8893769 [details] [diff] [review] Add text-rendering:optimizeLegibility to reftests for bug 1089388, to try and ensure we get proper glyph bounds Review of attachment 8893769 [details] [diff] [review]: ----------------------------------------------------------------- I certainly prefer fixing over fuzzing. Thanks very much!
Attachment #8893769 - Flags: review?(gbrown) → review+
3 years ago
OK, let's give this a try. If the problem happens again after this is landed, we can still fall back on a fuzz annotation.
https://hg.mozilla.org/integration/mozilla-inbound/rev/170429ba9a954f0d9794f58e549b61aa1751362d Bug 1316770 - Add text-rendering:optimizeLegibility to reftests for bug 1089388, to try and ensure we get proper glyph bounds. r=gbrown
You need to log in before you can comment on or make changes to this bug.