Closed Bug 1316770 Opened 3 years ago Closed 3 years ago

Intermittent writing-mode/1089388-1.html == writing-mode/1089388-1-ref.html | image comparison, max difference: 208, number of differing pixels: 3

Categories

(Core :: Layout: Block and Inline, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox56 --- fixed
firefox57 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: jfkthame)

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

Component: Layout → Layout: Block and Inline
Attached patch add fuzzy (obsolete) — Splinter Review
Is it okay to avoid the on-going intermittent failures here with fuzzy(), or is more investigation required?

Recent failures look like:

https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/FXCLEh-bTVaKekjh4NXG7Q/runs/0/artifacts/public/logs/live_backing.log
Attachment #8893473 - Flags: review?(jfkthame)
I think we may be able to fix this by adding text-rendering:optimizeLegibility to the testcases, to ensure we get actual glyph bounds for invalidation/painting purposes (instead of potentially using approximate bounds based on advance width and font height).
Could we give this a try, before resorting to adding fuzz annotations? I pushed it to tryserver (https://treeherder.mozilla.org/#/jobs?repo=try&revision=059a6cf35dcac2cb713a65745ad1477a2bf42d25) and so far haven't seen a failure there, though this is rare enough that it's hard to really be confident.
Attachment #8893769 - Flags: review?(gbrown)
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Comment on attachment 8893769 [details] [diff] [review]
Add text-rendering:optimizeLegibility to reftests for bug 1089388, to try and ensure we get proper glyph bounds

Review of attachment 8893769 [details] [diff] [review]:
-----------------------------------------------------------------

I certainly prefer fixing over fuzzing. Thanks very much!
Attachment #8893769 - Flags: review?(gbrown) → review+
Attachment #8893473 - Attachment is obsolete: true
Attachment #8893473 - Flags: review?(jfkthame)
OK, let's give this a try. If the problem happens again after this is landed, we can still fall back on a fuzz annotation.
https://hg.mozilla.org/integration/mozilla-inbound/rev/170429ba9a954f0d9794f58e549b61aa1751362d
Bug 1316770 - Add text-rendering:optimizeLegibility to reftests for bug 1089388, to try and ensure we get proper glyph bounds. r=gbrown
https://hg.mozilla.org/mozilla-central/rev/170429ba9a95
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.