Don't hold a ref to KnowsCompositor on the video manager thread

RESOLVED FIXED in Firefox 52

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

Tracking

Trunk
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Created attachment 8809663 [details] [diff] [review]
dont-hold-ref-on-video-thread

This is often a ShadowLayerForwarder, which although implements threadsafe refcounting, is not really threadsafe at all.

I want to fix this properly (by removing threadsafe refcounting, and fixing the places that it triggers), but that's a lot of work.

For now, this just removes the references from the video manager thread, which is the only one specific to OOP video decoding.
Attachment #8809663 - Flags: review?(dvander)
Attachment #8809663 - Flags: review?(dvander) → review+

Comment 1

2 years ago
Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/94e24024f3d9
Don't hold a KnowsCompositor ref on the video manager thread since we don't want it to outlive the main thread ref. r=dvander

Comment 2

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/94e24024f3d9
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.