Closed Bug 1316771 Opened 3 years ago Closed 3 years ago

Don't hold a ref to KnowsCompositor on the video manager thread

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

Details

Attachments

(1 file)

This is often a ShadowLayerForwarder, which although implements threadsafe refcounting, is not really threadsafe at all.

I want to fix this properly (by removing threadsafe refcounting, and fixing the places that it triggers), but that's a lot of work.

For now, this just removes the references from the video manager thread, which is the only one specific to OOP video decoding.
Attachment #8809663 - Flags: review?(dvander)
Attachment #8809663 - Flags: review?(dvander) → review+
Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/94e24024f3d9
Don't hold a KnowsCompositor ref on the video manager thread since we don't want it to outlive the main thread ref. r=dvander
https://hg.mozilla.org/mozilla-central/rev/94e24024f3d9
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.