Created attachment 8809663 [details] [diff] [review] dont-hold-ref-on-video-thread This is often a ShadowLayerForwarder, which although implements threadsafe refcounting, is not really threadsafe at all. I want to fix this properly (by removing threadsafe refcounting, and fixing the places that it triggers), but that's a lot of work. For now, this just removes the references from the video manager thread, which is the only one specific to OOP video decoding.
Attachment #8809663 - Flags: review?(dvander)
Attachment #8809663 - Flags: review?(dvander) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/94e24024f3d9 Don't hold a KnowsCompositor ref on the video manager thread since we don't want it to outlive the main thread ref. r=dvander
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.