1316815 - Wasm baseline: Make RegI32, RegI64, RegF32, RegF64 inherit from, not wrap, Register, Register64, FloatRegister

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect, P5)

Description

[Lars T Hansen [:lth]]

Making the change specified in the Summary will probably simplify the compiler some (and will reduce code) while maintaining the strong typing we get from these classes, stronger than what using the Register/Register64/FloatRegister types directly would give us.

This is probably mostly grunt work with a broad impact, all the ".reg" phrases will have to go away.

Comment 1

[(Away)]

Dipping a toe into wasm. Grunt work accepted!

Comment 2

[(Away)]

Attachment: patch v1

This was mostly automated. Here were my steps:

* s/.reg.reg/.foo/g
* s/.reg//g
* s/.foo/.reg/g
* Fix up allocInt64 and freeInt64, where I over-corrected
* Fix up OutOfLineTruncateF32OrF64ToI32::generate, where the arms of the ternary were no longer the same type

Lars, do you have any suggestions for what builds and/or testing I should do?

Comment 3

[Lars T Hansen [:lth]]

Comment on attachment 8811100 [details] [diff] [review]
patch v1

Review of attachment 8811100 [details] [diff] [review]:
-----------------------------------------------------------------

This seems very plausible.  (You'll have a little merge pain because of some things I landed today, but so will I for an outstanding fix after you land this :)

To test, I usually just run "./jit_test.py ../build-debug/dist/bin/js wasm asm.js" in js/src/jit-test to test wasm changes, it'll test both the regular compiler and the baseline compiler.  All of that runs on check-in, too, on all platforms.

If you want to be more comprehensive, build Firefox, enable both wasm and wasm_baseline in about:config, clone https://github.com/WebAssembly/website,  and load demo/AngryBots/index.html, you should be able to play the game without crashing.

Comment 4

[(Away)]

Thanks for the pointers. I pulled a fresh m-i and reapplied my substitutions from scratch. jit-tests and the demo game look good.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2cd76a9f89d3
Make RegI32, RegI64, RegF32, RegF64 inherit from, not wrap, Register, Register64, FloatRegister. r=lth

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/37dce5270b23
followup build fix on a CLOSED TREE

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2cd76a9f89d3
https://hg.mozilla.org/mozilla-central/rev/37dce5270b23