Refactor Firefox UI tests to directly use MarionetteTestCase and PuppeteerMixin

RESOLVED FIXED in Firefox 52

Status

Testing
Firefox UI Tests
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

Version 3
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(4 attachments)

(Assignee)

Description

a year ago
Next step to for our tests should be to use the MarionetteTestCase class directly, and if necessary also the PuppeteerMixin class.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Attachment #8809792 - Flags: review?(mjzffr)
Attachment #8809793 - Flags: review?(mjzffr)
Attachment #8809794 - Flags: review?(mjzffr)
Attachment #8809795 - Flags: review?(mjzffr)

Comment 6

a year ago
mozreview-review
Comment on attachment 8809792 [details]
Bug 1316851 - Firefox UI tests have to use super() to call base class methods.

https://reviewboard.mozilla.org/r/92304/#review92432
Attachment #8809792 - Flags: review?(mjzffr) → review+

Comment 7

a year ago
mozreview-review
Comment on attachment 8809793 [details]
Bug 1316851 - Firefox UI harness has to use super() to call base class methods.

https://reviewboard.mozilla.org/r/92306/#review92434
Attachment #8809793 - Flags: review?(mjzffr) → review+

Comment 8

a year ago
mozreview-review
Comment on attachment 8809794 [details]
Bug 1316851 - Puppeteer has to use super() to call base class methods.

https://reviewboard.mozilla.org/r/92308/#review92436
Attachment #8809794 - Flags: review?(mjzffr) → review+

Comment 9

a year ago
mozreview-review
Comment on attachment 8809795 [details]
Bug 1316851 - Testcases should directly inherit from MarionetteTestCase and PuppeteerMixin.

https://reviewboard.mozilla.org/r/92310/#review92438
Attachment #8809795 - Flags: review?(mjzffr) → review+

Comment 10

a year ago
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cd498d1a4490
Firefox UI tests have to use super() to call base class methods. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/ad8f42a8e7f6
Firefox UI harness has to use super() to call base class methods. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/608cebbca5c4
Puppeteer has to use super() to call base class methods. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/af0d5a28645e
Testcases should directly inherit from MarionetteTestCase and PuppeteerMixin. r=maja_zf

Comment 11

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/cd498d1a4490
https://hg.mozilla.org/mozilla-central/rev/ad8f42a8e7f6
https://hg.mozilla.org/mozilla-central/rev/608cebbca5c4
https://hg.mozilla.org/mozilla-central/rev/af0d5a28645e
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.