Closed Bug 1316869 Opened 4 years ago Closed 4 years ago

Custom tabs: Adapt text color based on toolbar color

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 52
Tracking Status
firefox52 --- fixed

People

(Reporter: sebastian, Assigned: droeh)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1279278 introduced a colored toolbar for custom tabs. However the text color does not adapt. Whenever a custom tab with a very light color is opened the white text is almost unreadable.
This is an easy enough fix, I added ColorUtil functionality that picks black or white as a readable text color based on background color.
Assignee: nobody → droeh
Status: NEW → ASSIGNED
Attachment #8809836 - Flags: review?(s.kaspari)
Attachment #8809836 - Flags: review?(s.kaspari) → review+
Pushed by droeh@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0114eda62ce2
Choose black or white title text color for custom tabs toolbar based on background color. r=sebastian
https://hg.mozilla.org/mozilla-central/rev/0114eda62ce2
https://hg.mozilla.org/mozilla-central/rev/b2f9a7cdcb51
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
See Also: → 1317933
You need to log in before you can comment on or make changes to this bug.