Custom tabs: Adapt text color based on toolbar color

RESOLVED FIXED in Firefox 52

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: sebastian, Assigned: droeh)

Tracking

(Blocks 1 bug)

unspecified
Firefox 52
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment)

Bug 1279278 introduced a colored toolbar for custom tabs. However the text color does not adapt. Whenever a custom tab with a very light color is opened the white text is almost unreadable.
This is an easy enough fix, I added ColorUtil functionality that picks black or white as a readable text color based on background color.
Assignee: nobody → droeh
Status: NEW → ASSIGNED
Attachment #8809836 - Flags: review?(s.kaspari)
Attachment #8809836 - Flags: review?(s.kaspari) → review+
Pushed by droeh@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0114eda62ce2
Choose black or white title text color for custom tabs toolbar based on background color. r=sebastian
https://hg.mozilla.org/mozilla-central/rev/0114eda62ce2
https://hg.mozilla.org/mozilla-central/rev/b2f9a7cdcb51
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
See Also: → 1317933
You need to log in before you can comment on or make changes to this bug.