Fix page-worker SDK test addon intermittency and re-enable it

RESOLVED FIXED in Firefox 53

Status

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: rpl, Assigned: rpl)

Tracking

unspecified
mozilla53

Firefox Tracking Flags

(firefox50 wontfix, firefox51 wontfix, firefox52 wontfix, firefox53 fixed)

Details

Attachments

(1 attachment)

The page-worker SDK test addon (addon-sdk/source/test/addon/page-worker) has been recently disable as part of Bug 1288619 because it presents an high rate of intermittency.

The goal of this issue is get to the bottom of the reasons behind its intermittency and fix it to re-enable the SDK test addon.
See Also: → 1288708
See Also: → 1288619
Like I commented on https://bugzilla.mozilla.org/show_bug.cgi?id=1288619#c33

I've been fighting with this intermittent SDK test addon for a while, ironically my last push to try, that was still running while the patch that blacklist this test addon was landing in inbound, seems to have been able to run all the mochitest-jetpack test suite 20 times without any "page-worker test addon" failure :-|

- https://treeherder.mozilla.org/#/jobs?repo=try&revision=3abefc17080c9d74333a791d6dba32bbe1752408

And so, I'm going to attach the patch then was running in the above try push to this bugzilla issue, so that we can evaluate the applied tweaks and how they have fixed the intermittency and evaluate how we want to proceed.
One more try build in progress with the above patch applied:

- https://treeherder.mozilla.org/#/jobs?repo=try&revision=27b33a5e00f8935bff3d218961ec49b6924ba0bc
Attachment #8809842 - Flags: review?(dtownsend)
Comment on attachment 8809842 [details]
Bug 1316875 - Fix page-worker SDK test addon intermittency and re-enable it.

https://reviewboard.mozilla.org/r/92340/#review92440

I don't see it getting re-enabled here?
Attachment #8809842 - Flags: review?(dtownsend) → review+
(In reply to Dave Townsend [:mossop] from comment #4)
> Comment on attachment 8809842 [details]
> Bug 1316875 - Fix page-worker SDK test addon intermittency and re-enable it.
> 
> https://reviewboard.mozilla.org/r/92340/#review92440
> 
> I don't see it getting re-enabled here?

Yep, the "blacklist" patch was still on inbound and my patch was applied on mozilla-central, but I wanted to push it asap one more time to try, and check that it is consistently green.

I'm going to rebase it on that patch and add the "de-blacklisting" part.
Assignee: nobody → lgreco
Rebased patch (which includes the "un-blacklisting" part) pushed to try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2f0a12ea21f180caae41e9770c01568a46ef50e0

In the above try push  mochitest-jetpack has run 20 times (using --rebuild 20) with no intermittent failures.
Status: NEW → ASSIGNED
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8223561e3700
Fix page-worker SDK test addon intermittency and re-enable it. r=mossop
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8223561e3700
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.