1316888 - Port sdp_unittest to xul gtest

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P1)

Description

[Dan Minor [:dminor]]

This is likely a good place to start when converting the signaling tests to run inside xul gtest.

Comment 1

[Eric Rahm [:erahm]]

I think this already has a patch in bug 1257713.

Comment 2

[Dan Minor [:dminor]]

Attachment: Bug 1316888 - Port sdp_unittests to xul gtest;

Review commit: https://reviewboard.mozilla.org/r/92478/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92478/

Comment 3

[Dan Minor [:dminor]]

Try run here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=54fd827c40538ee02a28d39f27950c0c8e509e4f

Comment 4

[Byron Campen [:bwc]]

Comment on attachment 8810005 [details]
Bug 1316888 - Port sdp_unittests to xul gtest;

https://reviewboard.mozilla.org/r/92478/#review92814

Comment 5

[Dan Minor [:dminor]]

Comment on attachment 8810005 [details]
Bug 1316888 - Port sdp_unittests to xul gtest;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92478/diff/1-2/

Comment 6

[Dan Minor [:dminor]]

Comment on attachment 8810005 [details]
Bug 1316888 - Port sdp_unittests to xul gtest;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92478/diff/2-3/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5beca5806805
Port sdp_unittests to xul gtest; r=bwc

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5beca5806805