Closed Bug 1316904 Opened 3 years ago Closed 3 years ago

Convert windows XPCOM tests to gtest

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: erahm, Assigned: erahm)

References

Details

Attachments

(1 file)

This converts TestNtPathToDosPath and TestCOM to gtests.

MozReview-Commit-ID: EeNwvsj4cAs
This converts the windows specific tests to gtests.
Attachment #8809885 - Flags: review?(nfroyd)
Comment on attachment 8809885 [details] [diff] [review]
Convert windows XPCOM tests to gtest

Review of attachment 8809885 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with removing these from testing/cppunittest.ini as well.

::: xpcom/tests/windows/moz.build
@@ +9,5 @@
> +    'TestNtPathToDosPath.cpp',
> +]
> +
> +LOCAL_INCLUDES += [
> +    '../../base',

What header is this for that's not already exported?

@@ +15,4 @@
>  
>  OS_LIBS += [
> +#    'rpcrt4',
> +#    'uuid',

Remove these lines?
Attachment #8809885 - Flags: review?(nfroyd) → review+
(In reply to Nathan Froyd [:froydnj] from comment #3)
> Comment on attachment 8809885 [details] [diff] [review]
> Convert windows XPCOM tests to gtest
> 
> Review of attachment 8809885 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me with removing these from testing/cppunittest.ini as well.

Will do.

> ::: xpcom/tests/windows/moz.build
> @@ +9,5 @@
> > +    'TestNtPathToDosPath.cpp',
> > +]
> > +
> > +LOCAL_INCLUDES += [
> > +    '../../base',
> 
> What header is this for that's not already exported?

I was just copying what the xpcom/tests/gtest/moz.build file does, I can push to try without it I guess.

> @@ +15,4 @@
> >  
> >  OS_LIBS += [
> > +#    'rpcrt4',
> > +#    'uuid',
> 
> Remove these lines?

Will do.
https://hg.mozilla.org/mozilla-central/rev/66f3aa6ea71b
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.