Closed
Bug 1316904
Opened 8 years ago
Closed 8 years ago
Convert windows XPCOM tests to gtest
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
References
Details
Attachments
(1 file)
|
11.03 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
This converts TestNtPathToDosPath and TestCOM to gtests. MozReview-Commit-ID: EeNwvsj4cAs
|
Assignee | |
Comment 1•8 years ago
|
||
This converts the windows specific tests to gtests.
Attachment #8809885 -
Flags: review?(nfroyd)
|
|
Assignee | |
Comment 2•8 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=490f214de3d9e67cf1038668f3f01f779a9122a8
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8809885 [details] [diff] [review] Convert windows XPCOM tests to gtest Review of attachment 8809885 [details] [diff] [review]: ----------------------------------------------------------------- r=me with removing these from testing/cppunittest.ini as well. ::: xpcom/tests/windows/moz.build @@ +9,5 @@ > + 'TestNtPathToDosPath.cpp', > +] > + > +LOCAL_INCLUDES += [ > + '../../base', What header is this for that's not already exported? @@ +15,4 @@ > > OS_LIBS += [ > +# 'rpcrt4', > +# 'uuid', Remove these lines?
Attachment #8809885 -
Flags: review?(nfroyd) → review+
|
|
Assignee | |
Comment 4•8 years ago
|
||
(In reply to Nathan Froyd [:froydnj] from comment #3) > Comment on attachment 8809885 [details] [diff] [review] > Convert windows XPCOM tests to gtest > > Review of attachment 8809885 [details] [diff] [review]: > ----------------------------------------------------------------- > > r=me with removing these from testing/cppunittest.ini as well. Will do. > ::: xpcom/tests/windows/moz.build > @@ +9,5 @@ > > + 'TestNtPathToDosPath.cpp', > > +] > > + > > +LOCAL_INCLUDES += [ > > + '../../base', > > What header is this for that's not already exported? I was just copying what the xpcom/tests/gtest/moz.build file does, I can push to try without it I guess. > @@ +15,4 @@ > > > > OS_LIBS += [ > > +# 'rpcrt4', > > +# 'uuid', > > Remove these lines? Will do.
|
|
Assignee | |
Comment 5•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c1351eab4b94
|
|
Assignee | |
Comment 6•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/66f3aa6ea71b76f3121f19384ec8e2e7dd18eada Bug 1316904 - Convert windows XPCOM tests to gtest. r=froydnj
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/66f3aa6ea71b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•