Do not include BuddyBuild in release builds

RESOLVED FIXED

Status

Focus-iOS
General
P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: st3fan, Assigned: st3fan)

Tracking

Other
iOS

Details

(Whiteboard: [MobileAS])

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Only include BuddyBuild in DEBUG builds. Do not call .setup() and do not link against the framework in release builds.
(Assignee)

Comment 2

a year ago
This patch does the following:

It introduces a conditional compilation option for Swift (`SWIFT_ACTIVE_COMPILATION_CONDITIONS`) named `BUDDYBUILD`. This option is set for the *FocusDebug*, *KlarDebug* and *FocusEnterprise* build configurations. Only in the *Blockzilla* target.

It removes the `BuddyBuildSDK.framework` from all targets. We keep it in the project so that it can be found, but by default it is not part of any target.

It adds `-framework BuddyBuildSDK` to the `OTHER_LDFLAGS` build setting for the *FocusDebug*, *KlarDebug* and *FocusEnterprise* build configurations.

In `application(didFinishLaunchingWithOptions:)` it condtionally includes the code to setup BuddyBuild in , based on the `BUDDYBUILD` compilation option. If it is not set then the code is not included at all and no frameworks are referenced.

> (This patch started as *Only enable BuddyBuild for DEBUG builds*. But that implies that we would also have to change the *FocusEnterprise*, which is currently not a DEBUG build.  I think is a bit too scary, since we also need to send that build out to early testers. So nothing changed regarding build settings. Just a new `BUDDYBUILD` compile option to specify per build config if it should ship with BB or not.)
(Assignee)

Updated

a year ago
Summary: Only include BuddyBuild in DEBUG builds → Do not include BuddyBuild in release builds
Attachment #8809920 - Flags: review?(bnicholson) → review+
(Assignee)

Updated

a year ago
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.