Closed Bug 1316951 Opened 3 years ago Closed 3 years ago

"select" events fired by HTMLInputElement should always be trusted

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file, 1 obsolete file)

They represent the browser really planning to select the control contents.

The current "only fire trusted if chrome or system caller" behavior dates all the way back to but 289940 and I think is just wrong.
This doesn't make the html/semantics/forms/textfieldselection/select-event.html web platform test pass, due to bug 1316982.
Attachment #8809957 - Flags: review?(bugs)
Attachment #8809941 - Attachment is obsolete: true
Attachment #8809941 - Flags: review?(bugs)
Comment on attachment 8809957 [details] [diff] [review]
The "select" events fired by HTMLInputElement code should always be trusted, since they always correspond to an actual attempt by the browser to select the text in the control

ancient code.

There are some other issues related to isTrusted handling, but need to fix those in other bugs.
Attachment #8809957 - Flags: review?(bugs) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8dab325ec3f6
The "select" events fired by HTMLInputElement code should always be trusted, since they always correspond to an actual attempt by the browser to select the text in the control.  r=smaug
https://hg.mozilla.org/mozilla-central/rev/8dab325ec3f6
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.