1316981 - FTLParser should setPosition on AST nodes

Status: RESOLVED WORKSFORME

(L20n :: Python Library, defect)

Description

[Axel Hecht [:Pike]]

Right now, the primary use-case for the python parser is tooling, and for that, having source positions are crucial.

We should setPosition() on AST nodes in the parser.

Maybe doing that optionally. There's a with_source in the migration branch by stas, maybe that's the same switch

Comment 1

[Axel Hecht [:Pike]]

Attachment: First phase

Gandalf did a first pass on this that we merged with https://github.com/l20n/python-l20n/pull/7.

Sadly, that's not working out great, I'll follow up with a PR that adds tests, which fail on value parsing.

There's a trailing whitespace problem, start of values with placables start as that start of the placable, not the value, trait keys have no space.

The test isn't going very deep yet, it's mostly covering what I'd need to integrate compare-locales and elmo, which is very entity focuses, and ignores sections and comments.

Comment 2

[Axel Hecht [:Pike]]

Attachment: Tests that fail but should pass.

Comment 3

[Axel Hecht [:Pike]]

Resolving this as WORKSFORME, as I think we have all the positions (for the ASTs we have) now, but probably did that differently than this bug expected.