Closed
Bug 1316984
Opened 8 years ago
Closed 8 years ago
Update Puppeteer modules for APIs added to Marionette
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(firefox52 fixed, firefox53 fixed)
RESOLVED
FIXED
mozilla53
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
(Keywords: pi-marionette-firefox-puppeteer)
Attachments
(4 files, 2 obsolete files)
When all the work on bug 1310632 is done we have to update our Puppeteer modules for those APIs which have been added into Marionette. Therefore a new release of the marionette_driver package will be necessary. Any bugs for API changes will be also added as dependencies here.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•8 years ago
|
||
The already attached patch has been stripped of from the commit series on bug 1308902 and was already reviewed there. I will wait for another review until we can actually apply this patch.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•8 years ago
|
||
We are about to move Puppeteer to testing/marionette. So we should better wait for it.
Depends on: 1319705
Assignee | ||
Comment 4•8 years ago
|
||
We are blocked on new releases of the client and harness packages. Once those have been released we can get rid of the old code.
Depends on: 1320073
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 9•8 years ago
|
||
Last try build shows a problem with an import line I missed to actually commit before I pushed to mozreview. But external-media-tests working fine. https://treeherder.mozilla.org/#/jobs?repo=try&revision=688d859e7837 I will fix this failure, and bump the puppeteer version too.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Attachment #8809959 -
Flags: review?(mjzffr)
Attachment #8818554 -
Flags: review?(mjzffr)
Attachment #8818555 -
Flags: review?(bvandyk)
Attachment #8818556 -
Flags: review?(mjzffr)
Attachment #8818585 -
Flags: review?(mjzffr)
Attachment #8818586 -
Flags: review?(mjzffr)
Comment 13•8 years ago
|
||
mozreview-review |
Comment on attachment 8818555 [details] Bug 1316984 - Update external media tests to get/set preferences via Marionette. https://reviewboard.mozilla.org/r/98606/#review99008
Attachment #8818555 -
Flags: review?(bvandyk) → review+
Assignee | ||
Comment 14•8 years ago
|
||
Bug 1277090 seems to be another blocker before we actually can land this patch series. It would cause another release of the marionette-driver package, so some patches need an update here.
Depends on: 1277090
Assignee | ||
Updated•8 years ago
|
Attachment #8809959 -
Flags: review?(mjzffr)
Attachment #8818585 -
Flags: review?(mjzffr)
Attachment #8818586 -
Flags: review?(mjzffr)
Assignee | ||
Comment 15•8 years ago
|
||
I was thinking more about this situation and I feel we should indeed get this bug solved first before bug 1277090. Reason is that if we don't do that we have get_property() calls which are related to l10n AND the Javascript properties of elements. This can be really confusing. So lets flip the dependency order and get this bug fixed without a puppeteer release.
Assignee | ||
Updated•8 years ago
|
status-firefox52:
--- → affected
status-firefox53:
--- → affected
Component: Firefox UI Tests → Marionette
Keywords: ateam-marionette-firefox-puppeteer
QA Contact: hskupin
Assignee | ||
Updated•8 years ago
|
Attachment #8809959 -
Flags: review?(mjzffr)
Assignee | ||
Updated•8 years ago
|
Attachment #8818585 -
Attachment is obsolete: true
Assignee | ||
Updated•8 years ago
|
Attachment #8818586 -
Attachment is obsolete: true
Comment 16•8 years ago
|
||
mozreview-review |
Comment on attachment 8809959 [details] Bug 1316984 - Bump marionette-driver dependency to 2.2.0. https://reviewboard.mozilla.org/r/92436/#review99496
Attachment #8809959 -
Flags: review?(mjzffr) → review+
Comment 17•8 years ago
|
||
mozreview-review |
Comment on attachment 8818554 [details] Bug 1316984 - Update Puppeteer to use new localization module of Marionette. https://reviewboard.mozilla.org/r/98604/#review99500
Attachment #8818554 -
Flags: review?(mjzffr) → review+
Comment 18•8 years ago
|
||
mozreview-review |
Comment on attachment 8818556 [details] Bug 1316984 - Remove prefs module from Firefox Puppeteer. https://reviewboard.mozilla.org/r/98608/#review99502
Attachment #8818556 -
Flags: review?(mjzffr) → review+
Comment 19•8 years ago
|
||
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dba703809fea Bump marionette-driver dependency to 2.2.0. r=maja_zf https://hg.mozilla.org/integration/autoland/rev/e56429e854a4 Update Puppeteer to use new localization module of Marionette. r=maja_zf https://hg.mozilla.org/integration/autoland/rev/499f2417ea87 Update external media tests to get/set preferences via Marionette. r=SingingTree https://hg.mozilla.org/integration/autoland/rev/37dab4ba15cc Remove prefs module from Firefox Puppeteer. r=maja_zf
Comment 20•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/dba703809fea https://hg.mozilla.org/mozilla-central/rev/e56429e854a4 https://hg.mozilla.org/mozilla-central/rev/499f2417ea87 https://hg.mozilla.org/mozilla-central/rev/37dab4ba15cc
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Assignee | ||
Comment 21•7 years ago
|
||
There is a bug in Marionette as reported as bug 1324373 which needs to be fixed first before an uplift to aurora can be requested.
Depends on: 1324373
Comment 22•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/c4ac90bdaaa3 https://hg.mozilla.org/releases/mozilla-aurora/rev/4f352e05e27f https://hg.mozilla.org/releases/mozilla-aurora/rev/738eff2f2aa2 https://hg.mozilla.org/releases/mozilla-aurora/rev/5434909ba45c
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•