Closed Bug 1316984 Opened 3 years ago Closed 3 years ago

Update Puppeteer modules for APIs added to Marionette

Categories

(Testing :: Marionette, defect)

Version 3
defect
Not set

Tracking

(firefox52 fixed, firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Keywords: pi-marionette-firefox-puppeteer)

Attachments

(4 files, 2 obsolete files)

When all the work on bug 1310632 is done we have to update our Puppeteer modules for those APIs which have been added into Marionette. Therefore a new release of the marionette_driver package will be necessary.

Any bugs for API changes will be also added as dependencies here.
The already attached patch has been stripped of from the commit series on bug 1308902 and was already reviewed there. I will wait for another review until we can actually apply this patch.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
We are about to move Puppeteer to testing/marionette. So we should better wait for it.
Depends on: 1319705
We are blocked on new releases of the client and harness packages. Once those have been released we can get rid of the old code.
Depends on: 1320073
Last try build shows a problem with an import line I missed to actually commit before I pushed to mozreview. But external-media-tests working fine.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=688d859e7837

I will fix this failure, and bump the puppeteer version too.
Attachment #8809959 - Flags: review?(mjzffr)
Attachment #8818554 - Flags: review?(mjzffr)
Attachment #8818555 - Flags: review?(bvandyk)
Attachment #8818556 - Flags: review?(mjzffr)
Attachment #8818585 - Flags: review?(mjzffr)
Attachment #8818586 - Flags: review?(mjzffr)
Comment on attachment 8818555 [details]
Bug 1316984 - Update external media tests to get/set preferences via Marionette.

https://reviewboard.mozilla.org/r/98606/#review99008
Attachment #8818555 - Flags: review?(bvandyk) → review+
Bug 1277090 seems to be another blocker before we actually can land this patch series. It would cause another release of the marionette-driver package, so some patches need an update here.
Depends on: 1277090
Attachment #8809959 - Flags: review?(mjzffr)
Attachment #8818585 - Flags: review?(mjzffr)
Attachment #8818586 - Flags: review?(mjzffr)
I was thinking more about this situation and I feel we should indeed get this bug solved first before bug 1277090. Reason is that if we don't do that we have get_property() calls which are related to l10n AND the Javascript properties of elements. This can be really confusing.

So lets flip the dependency order and get this bug fixed without a puppeteer release.
Blocks: 1277090
No longer depends on: 1277090
Component: Firefox UI Tests → Marionette
QA Contact: hskupin
Attachment #8809959 - Flags: review?(mjzffr)
Attachment #8818585 - Attachment is obsolete: true
Attachment #8818586 - Attachment is obsolete: true
Comment on attachment 8809959 [details]
Bug 1316984 - Bump marionette-driver dependency to 2.2.0.

https://reviewboard.mozilla.org/r/92436/#review99496
Attachment #8809959 - Flags: review?(mjzffr) → review+
Comment on attachment 8818554 [details]
Bug 1316984 - Update Puppeteer to use new localization module of Marionette.

https://reviewboard.mozilla.org/r/98604/#review99500
Attachment #8818554 - Flags: review?(mjzffr) → review+
Comment on attachment 8818556 [details]
Bug 1316984 - Remove prefs module from Firefox Puppeteer.

https://reviewboard.mozilla.org/r/98608/#review99502
Attachment #8818556 - Flags: review?(mjzffr) → review+
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dba703809fea
Bump marionette-driver dependency to 2.2.0. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/e56429e854a4
Update Puppeteer to use new localization module of Marionette. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/499f2417ea87
Update external media tests to get/set preferences via Marionette. r=SingingTree
https://hg.mozilla.org/integration/autoland/rev/37dab4ba15cc
Remove prefs module from Firefox Puppeteer. r=maja_zf
There is a bug in Marionette as reported as bug 1324373 which needs to be fixed first before an uplift to aurora can be requested.
Depends on: 1324373
You need to log in before you can comment on or make changes to this bug.