Closed
Bug 1317013
Opened 8 years ago
Closed 6 years ago
selfserv doesn't report "tls1.3" as an option when TLS 1.3 is enabled
Categories
(NSS :: Tools, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
3.40
People
(Reporter: mt, Assigned: manishkk)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
|
1009 bytes,
patch
|
mt
:
review+
mt
:
checked-in+
|
Details | Diff | Splinter Review |
The usage output doesn't include tls1.3 when that is a possibility.
|
Assignee | |
Comment 1•6 years ago
|
||
I would like to work on this bug! Please let me know what exactly I need to do?
Flags: needinfo?(martin.thomson)
|
Reporter | |
Comment 2•6 years ago
|
||
Change the help text in selfserv.c to include tls1.3.
Flags: needinfo?(martin.thomson)
|
|
Assignee | |
Comment 3•6 years ago
|
||
Please can u mention exact line #
Assignee: nobody → 1991manish.kumar
|
|
Reporter | |
Comment 4•6 years ago
|
||
That is best left as an exercise for you. Maybe start by searching for "tls1.2".
|
|
Assignee | |
Comment 5•6 years ago
|
||
Please review!
Attachment #9006092 -
Flags: review?(martin.thomson)
|
|
Reporter | |
Comment 6•6 years ago
|
||
Comment on attachment 9006092 [details] [diff] [review] Patch_Bug1317013 Review of attachment 9006092 [details] [diff] [review]: ----------------------------------------------------------------- Thanks. https://hg.mozilla.org/projects/nss/rev/22c307916092cb7ff109d40325c9d8b506459f00
Attachment #9006092 -
Flags: review?(martin.thomson)
Attachment #9006092 -
Flags: review+
Attachment #9006092 -
Flags: checked-in+
|
|
Reporter | |
Comment 7•6 years ago
|
||
For future reference, we're now doing reviews on phabricator: https://phabricator.services.mozilla.com/ Any substantial change will need to uploaded there.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.40
You need to log in
before you can comment on or make changes to this bug.
Description
•