1317104 - Backspace in address bar does not remove the URL auto-complete suggestion

Status: RESOLVED FIXED

(Focus-iOS :: General, defect, P1)

Description

[Chris Peterson [:cpeterson]]

STR:
1. Open Firefox Focus
2. Tap input focus to the address bar
3. Type 'g'
4. Watch the address bar suggest "google.com/"
5. Press backspace to delete the 'g' character

RESULT:
The address bar will now show "oogle.com/" instead of returning to its initial empty state.

The "Search for" suggestion bar will still "Search for g", even though I deleted 'g' from the address bar.

Comment 1

[Brian Nicholson (:bnicholson)]

I'm having trouble reproducing this or bug 1317105. Which device/iOS version are you on? Are you just using the standard system keyboard?

Comment 2

[Brian Nicholson (:bnicholson)]

I am able to reproduce this and bug 1317105 with Gboard.

Comment 3

[Brian Nicholson (:bnicholson)]

In my case, the issue is that Gboard doesn't fire textField(shouldChangeCharactersIn:) on deletions, which differs from the standard iOS keyboard behavior. Instead, the deletion fires deleteBackward(), so we can fix this by injecting our completion code there.

This should be fixed now for Gboard, and hopefully other keyboards as well. Chris, if you can let us know which keyboard you're using, I'll verify that the fix here works with it. Thanks for the report, as usual!

master: f53ec76

Comment 4

[Chris Peterson [:cpeterson]]

(In reply to Brian Nicholson (:bnicholson) from comment #3)
> This should be fixed now for Gboard, and hopefully other keyboards as well.
> Chris, if you can let us know which keyboard you're using, I'll verify that
> the fix here works with it. Thanks for the report, as usual!

I am using Gboard. Sorry I forgot to mention that! I've found other iOS apps that break when using Gboard, so I should have suspected that here.

Comment 5

[Brian Nicholson (:bnicholson)]

While the fix here works for Gboard, I've tested a few other third-party keyboards, and there are still a few issues we need to iron out. We've decided that it's safest to just disable third-party keyboards for Focus v2.0 (bug 1317396), and we can try to re-enable them in v2.1.