1317131 - wmode=direct (NHK Realtime News) Flash Video would not play since Nighyly52.0a1(2016-Nov-12)

Status: RESOLVED FIXED

(Core :: Graphics, defect, P1)

Description

[Alice0775 White]

[Tracking Requested - why for this release]: Regression Flash Video would not play 

NHK Realtime News video would not start.

If disable HWA, it works as expected.


Reproducible : 100%

Steps To Reproduce:
1. Open http://www3.nhk.or.jp/news/realtime-3/  (the URL may be expired soon)
   (Alternative: Open http://www3.nhk.or.jp/news/ and Click [LIVE] at the right side)



Actual Results:
Upper video(Flash Player) is black. Not playback.
(Lower one is HTML5, and no problem)

Expected Results:
Upper video(Flash Player) will playback automatically when page is loaded.


Regression Window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=2716f83ffcc0d9adbe37cc7bd4b06a54e4a81abd&tochange=ce4e1e1d0bff70ea540d62eca9e0720853610700


Suspect: 	e9db19aed6c0	Kevin Chen — Bug 1160157 - Use AutoTextureLock to manage the shared resource's mutex. r=dvander

Comment 1

[Alice0775 White]

Attachment: testcase wmode=direct

Comment 2

[Alice0775 White]

Reproduced on current release Flash Player 23.0.0.207 as well as beta 24.0.0.154.

Comment 3

[Alice0775 White]

http://www3.nhk.or.jp/nhkworld/en/live/ also affected.

Comment 4

[Alice0775 White]

Same problem is back!!! (See old Bug 1311952).

Please provide automatetest, Otherwise, any patch should not be landed!!!!

Comment 5

[Alice0775 White]

I confirmed via local build that Bug 1160157 causes the problem:
Last Good: 2716f83ffcc0
First Bad: e9db19aed6c0

Regressed by: 	e9db19aed6c0	Kevin Chen — Bug 1160157 - Use AutoTextureLock to manage the shared resource's mutex. r=dvander

Comment 6

[Peter Chang[:pchang]]

kevin, please take a look.

Comment 7

[Kevin Chen[:kechen] (UTC + 8)]

Attachment: Fix the incorrect AutoTextureLock lifecycle.

The reason of this error is that I didn't hold the AutoTextureLock object when constructing it in these two cases.

This problem can be fixed by the patch. I will mark r? when the try run is completed.

Comment 8

[Kevin Chen[:kechen] (UTC + 8)]

Comment on attachment 8810322 [details] [diff] [review]
Fix the incorrect AutoTextureLock lifecycle.

Hello David, can you help me to review this patch. The detail about this patch is in comment 7.

The try run looks good[1], there are two timeout in Windows 7 VM debug mochitest, but I think it is not related to this patch.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=83de1d5ee17020fbd0e9de82ce04e58b1a1bdd3f

Comment 9

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8810322 [details] [diff] [review]
Fix the incorrect AutoTextureLock lifecycle.

Review of attachment 8810322 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/plugins/ipc/D3D11SurfaceHolder.cpp
@@ -71,5 @@
>      return false;
>    }
>  
>    {
> -    AutoTextureLock(mutex, hr);

r=me on changing "class AutoTextureLock" to "class MOZ_RAII AutoTextureLock". Though the static analysis doesn't run on Windows :( that would have caught this.

Comment 10

[Kevin Chen[:kechen] (UTC + 8)]

Attachment: Fix the incorrect AutoTextureLock lifecycle.

Carry r+ from comment 9.

Comment 11

[Kevin Chen[:kechen] (UTC + 8)]

Attachment: Fix the incorrect AutoTextureLock lifecycle.

Approval Request Comment
[Feature/regressing bug #]: Bug 1160157
[User impact if declined]:
  Some shared source features on Windows platform won't work(e.g., Some flash videos can't be displayed).
[Describe test coverage new/current, TreeHerder]:
  None
[Risks and why]: 
  The risk is low, it add a local variable to hold the ref.
[String/UUID change made/needed]:
  None

Comment 12

[Carsten Book [:Tomcat]]

applying 0001-Bug-1317131-Fix-the-incorrect-AutoTextureLock-lifecy.patch
patching file gfx/layers/d3d11/TextureD3D11.cpp
Hunk #2 FAILED at 1230
1 out of 2 hunks FAILED -- saving rejects to file gfx/layers/d3d11/TextureD3D11.cpp.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh 0001-Bug-1317131-Fix-the-incorrect-AutoTextureLock-lifecy.patch

has problems to apply (or so we need the uplift patch here ?

Comment 13

[Marcia Knous [:marcia]]

Tracking 53+ for this issue - Can we get some automation to cover it so it doesn't happen again as is suggested in Comment 4?

Comment 14

[Kevin Chen[:kechen] (UTC + 8)]

Hello Carsten,

The conflict is caused by [1] which is landed several days ago.
Please apply Attachment #8811643 [details] [diff]. Thank you.

[1] https://hg.mozilla.org/mozilla-central/rev/86e2aea8417c

Comment 15

[Kevin Chen[:kechen] (UTC + 8)]

(In reply to Marcia Knous [:marcia - use ni] from comment #13)
> Tracking 53+ for this issue - Can we get some automation to cover it so it
> doesn't happen again as is suggested in Comment 4?

Yes, I will try to add an extra test for this bug.

Comment 16

[Alice0775 White]

(In reply to Kevin Chen[:kechen] (UTC + 8) from comment #14)
> Hello Carsten,
> 
> The conflict is caused by [1] which is landed several days ago.
> Please apply Attachment #8811643 [details] [diff] [diff]. Thank you.
> 
> [1] https://hg.mozilla.org/mozilla-central/rev/86e2aea8417c

Do you forget checking-needed flag?

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a524931c115b
Fix the incorrect AutoTextureLock lifecycle. r=dvander

Comment 18

[Alice0775 White]

Reproduced the problem on 2016-Nov-20日17 build[1].
Verified to fix the problem on 2016-Nov-20 build[2].

[1]https://hg.mozilla.org/mozilla-central/rev/57a8cde3f08ca9d60bcd8bdd698ceec687f0aed2
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0 ID:20161120030205
[2]

Comment 19

[Alice0775 White]

Sorry spam, please ignore comment#18

Comment 20

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a524931c115b

Comment 21

[Kevin Chen[:kechen] (UTC + 8)]

Since the bug is closed, I open Bug 1319354 to track the automatetest mentioned in Comment 4.

Comment 22

[Alice0775 White]

I can reproduce the problem on  Nightly 2016-Nov-21 build[1]
I can verify to fix the problem on Nightly 2016-Nov-22 build[2].

[1]
https://hg.mozilla.org/mozilla-central/rev/b7f895c1dc2e91530240efbf50ac063a0f8a9cb5
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0 ID:20161121030224

[2]
https://hg.mozilla.org/mozilla-central/rev/0534254e9a40b4bade2577c631fe4cfa0b5db41d
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0 ID:20161122030216


Please up lift this to Aurora52.0a2.

Comment 23

[Julien Cristau [:jcristau]]

Comment on attachment 8811643 [details] [diff] [review]
Fix the incorrect AutoTextureLock lifecycle.

fix regression on d3d11, take in aurora52

Comment 24

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/dc6138379852