1317174 - browser/base/content/test/general/browser_bug719271.js fails to run more than once in same browser session

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Vishnu (:malayaleecoder)]

./mach mochitest browser/base/content/test/general/browser_bug719271.js --repeat 1 fails.

Comment 1

[Vishnu (:malayaleecoder)]

Attachment: Bug1317174_v1.diff

This patch fixes this issue, but makes the subsequent check of "Initial zoom of tab 1" less strict. Please suggest if there is a way around it.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8810222 [details] [diff] [review]
Bug1317174_v1.diff

Review of attachment 8810222 [details] [diff] [review]:
-----------------------------------------------------------------

close!

::: browser/base/content/test/general/browser_bug719271.js
@@ +25,5 @@
>    Task.spawn(function* () {
>      is(gBrowser.selectedTab, gTab1, "Tab 1 is selected");
> +    level1 = ZoomManager.getZoomForBrowser(gBrowser.getBrowserForTab(gTab1));
> +    if(level1 > 1)
> +      FullZoom.reduce();

can you make level1 a variable?

I would add a comment "reset zoom level if we run this test >1 time"

Comment 3

[Vishnu (:malayaleecoder)]

Attachment: Bug1317174_v2.diff

Sorry, that was a typo.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8810462 [details] [diff] [review]
Bug1317174_v2.diff

Review of attachment 8810462 [details] [diff] [review]:
-----------------------------------------------------------------

In your commit message, please add a "r=jmaher" at the end.

::: browser/base/content/test/general/browser_bug719271.js
@@ +28,5 @@
> +    //Reset zoom level if we run this test > 1 time in same browser session.
> +    var level1 = ZoomManager.getZoomForBrowser(gBrowser.getBrowserForTab(gTab1));
> +    if(level1 > 1)
> +      FullZoom.reduce();
> +    

last small thing here, there is whitespace on line 32 although it is a blank line.  if you can upload another patch with this line actually 'blank', we can go ahead and land it.

Comment 5

[Vishnu (:malayaleecoder)]

Attachment: Bug1317174_v3.diff

:P

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/91db8a985f7f
Fix browser_bug719271.js to run multiple times in a single session r=jmaher

Comment 7

[Vishnu (:malayaleecoder)]

Attachment: Bug1317174_v4.diff

Resolved typo seen over here,
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=91db8a985f7fadecde63e3a4e20a4529fcdcc456&selectedJob=39156726

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f35b3bbdd3c5
Fix browser_bug719271.js to run multiple times in a single session: fix eslint failures. r=eslint-fix

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/91db8a985f7f
https://hg.mozilla.org/mozilla-central/rev/f35b3bbdd3c5

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/dbd635f89ddc