Closed Bug 1317180 Opened 5 years ago Closed 5 years ago

Remove some cruft from IPDL parser

Categories

(Core :: IPC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(8 files)

MessageId has the production "'~' ID", but if you use it, it produces an error: "sorry, `%s()' destructor syntax is a relic from a bygone era.  Declare `__delete__()' in the `%s' protocol instead". This warning message was added in 2009, in bug 525342, so I doubt anybody expects it to work any more, so it should just be a regular parse error.
Summary: Remove ~ cruft from MessageID case in IPDL parser → Remove some cruft from IPDL parser
try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3114604ce39331ab9277d951da3a8fd39e824402

There are a number of patches here, but they should all be simple.
Blocks: 1316757
Comment on attachment 8810599 [details]
Bug 1317180, part 1 - Remove trailing whitespace from ast.py and parser.py.

https://reviewboard.mozilla.org/r/92884/#review92894
Attachment #8810599 - Flags: review?(wmccloskey) → review+
Comment on attachment 8810600 [details]
Bug 1317180, part 2 - Remove really old ~ syntax error for MessageId in IPDL parser.

https://reviewboard.mozilla.org/r/92886/#review92896
Attachment #8810600 - Flags: review?(wmccloskey) → review+
Comment on attachment 8810601 [details]
Bug 1317180, part 3 - Remove unused ActorType syntax.

https://reviewboard.mozilla.org/r/92888/#review92898
Attachment #8810601 - Flags: review?(wmccloskey) → review+
Comment on attachment 8810602 [details]
Bug 1317180, part 4 - Inline ScalarType.

https://reviewboard.mozilla.org/r/92890/#review92902
Attachment #8810602 - Flags: review?(wmccloskey) → review+
Comment on attachment 8810603 [details]
Bug 1317180, part 5 - Get rid of the now-unused state field in TypeSpec.

https://reviewboard.mozilla.org/r/92892/#review92904
Attachment #8810603 - Flags: review?(wmccloskey) → review+
Comment on attachment 8810604 [details]
Bug 1317180, part 6 - Removed some unused arguments from TypeSpec ctor.

https://reviewboard.mozilla.org/r/92894/#review92906
Attachment #8810604 - Flags: review?(wmccloskey) → review+
Comment on attachment 8810605 [details]
Bug 1317180, part 7 - Remove TypeSpec fields myChmod and otherChmod that are never set.

https://reviewboard.mozilla.org/r/92896/#review92908
Attachment #8810605 - Flags: review?(wmccloskey) → review+
Comment on attachment 8810606 [details]
Bug 1317180, part 8 - Remove unused optional argument chmodallowed to _canonicalType.

https://reviewboard.mozilla.org/r/92898/#review92910
Attachment #8810606 - Flags: review?(wmccloskey) → review+
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/46626bec2598
part 1 - Remove trailing whitespace from ast.py and parser.py. r=billm
https://hg.mozilla.org/integration/autoland/rev/a8b85a9b7092
part 2 - Remove really old ~ syntax error for MessageId in IPDL parser. r=billm
https://hg.mozilla.org/integration/autoland/rev/04d44b806d48
part 3 - Remove unused ActorType syntax. r=billm
https://hg.mozilla.org/integration/autoland/rev/67e266ee225a
part 4 - Inline ScalarType. r=billm
https://hg.mozilla.org/integration/autoland/rev/e7059b65e7aa
part 5 - Get rid of the now-unused state field in TypeSpec. r=billm
https://hg.mozilla.org/integration/autoland/rev/9c02838f29ec
part 6 - Removed some unused arguments from TypeSpec ctor. r=billm
https://hg.mozilla.org/integration/autoland/rev/0dea817804ac
part 7 - Remove TypeSpec fields myChmod and otherChmod that are never set. r=billm
https://hg.mozilla.org/integration/autoland/rev/b7ccea321333
part 8 - Remove unused optional argument chmodallowed to _canonicalType. r=billm
You need to log in before you can comment on or make changes to this bug.