Current device and other devices in the Sync ping are inconsistent.

RESOLVED FIXED in Firefox 53

Status

()

defect
P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: markh, Assigned: markh)

Tracking

unspecified
Firefox 53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment)

In our telemetry ping, we record the hashed FxA device ID for the current device, but the hashed Sync client GUID for other devices. We should record consistent IDs - bug 1316535 is to try and use the FxA device ID in the future, but in the mean time we should consider using the client GUID for the current device so we can correlate these devices correctly across syncs.

Obvious downside here is that changing the ID might break some adhoc analysis, but I don't think we are using it too seriously yet, so changing it ASAP probably makes sense.
Comment on attachment 8810301 [details]
Bug 1317216 - consistently use the Sync client GUID as the basis for the device ID in the sync ping.

https://reviewboard.mozilla.org/r/92646/#review92740

Looks fine overall.

::: services/sync/modules/telemetry.js:290
(Diff revision 1)
>        let remoteDevices = Weave.Service.clientsEngine.remoteClients;
>        this.devices = remoteDevices.map(device => {
>          return {
>            os: device.os,
>            version: device.version,
> -          id: Utils.sha256(device.id + this.uid)
> +          id: Weave.Service.identity.hashedDeviceID(device.id),

I'm a little worried about doing a call that can throw here, but I guess if it was going to throw, includeDeviceInfo would be false, so I'm fine with it as is (just thought worth mentioning).
Attachment #8810301 - Flags: review?(tchiovoloni) → review+
Priority: -- → P1
Assignee: nobody → markh
Pushed by mhammond@skippinet.com.au:
https://hg.mozilla.org/integration/autoland/rev/25836ab7cdbc
consistently use the Sync client GUID as the basis for the device ID in the sync ping. r=tcsc
https://hg.mozilla.org/mozilla-central/rev/25836ab7cdbc
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in before you can comment on or make changes to this bug.