Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Intermittent toolkit/components/passwordmgr/test/mochitest/test_password_field_autocomplete.html | Test timed out.

RESOLVED FIXED in Firefox 52

Status

()

Toolkit
Password Manager
P1
normal
RESOLVED FIXED
8 months ago
6 months ago

People

(Reporter: Treeherder Bug Filer, Assigned: seanlee)

Tracking

({intermittent-failure})

unspecified
mozilla53
intermittent-failure
Points:
---

Firefox Tracking Flags

(firefox50 unaffected, firefox51 unaffected, firefox52 fixed, firefox53 fixed, firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

8 months ago
treeherder
Filed by: tomcat [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=39139285&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/eOrJ5MkcQDK-SaHDZp5_YQ/runs/0/artifacts/public%2Flogs%2Flive_backing.log
Blocks: 1289913
Flags: needinfo?(selee)
Assignee: nobody → selee
Status: NEW → ASSIGNED
Priority: -- → P1

Comment 1

8 months ago
30 failures in 124 pushes (0.242 failures/push) were associated with this bug yesterday.  

Repository breakdown:
* mozilla-inbound: 11
* autoland: 11
* try: 3
* mozilla-central: 3
* mozilla-aurora: 2

Platform breakdown:
* linux64: 27
* linux32: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1317284&startday=2016-11-14&endday=2016-11-14&tree=all
(Assignee)

Comment 2

8 months ago
I am trying to reproduce this at my local Linux x64 debug build now.
After talking with Sean I suggest he try to listen to this observer within restoreForm(), which re-construct the forms with innerHTML and triggers form fill.

http://searchfox.org/mozilla-central/rev/886d5186f0598ab2f8a9953eb5a4dab9750ef834/toolkit/components/passwordmgr/test/pwmgr_common.js#184-195
(Assignee)

Comment 4

8 months ago
Thanks for Tim's suggestion. Here is the try link with the patch of "passwordmgr-processed-form" observer solution.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=478b2e0545282ea2b87695a922f109d1ac1bd1b6
Flags: needinfo?(selee)

Comment 5

8 months ago
75 failures in 144 pushes (0.521 failures/push) were associated with this bug yesterday.  

Repository breakdown:
* mozilla-inbound: 39
* autoland: 23
* try: 7
* mozilla-aurora: 6

Platform breakdown:
* linux64: 63
* linux32: 12

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1317284&startday=2016-11-15&endday=2016-11-15&tree=all
(Assignee)

Comment 6

8 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7c8368653c61b83f79e47939cd144e4e374559f4
Comment hidden (mozreview-request)

Comment 8

8 months ago
69 failures in 119 pushes (0.58 failures/push) were associated with this bug yesterday.  

Repository breakdown:
* mozilla-inbound: 33
* autoland: 25
* mozilla-aurora: 4
* try: 3
* graphics: 3
* mozilla-central: 1

Platform breakdown:
* linux64: 52
* linux32: 17

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1317284&startday=2016-11-16&endday=2016-11-16&tree=all

Comment 9

8 months ago
90 failures in 147 pushes (0.612 failures/push) were associated with this bug yesterday.  

Repository breakdown:
* mozilla-inbound: 36
* autoland: 34
* try: 12
* mozilla-central: 7
* graphics: 1

Platform breakdown:
* linux64: 70
* linux32: 20

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1317284&startday=2016-11-17&endday=2016-11-17&tree=all
Whiteboard: [test disabled on Linux]

Comment 10

8 months ago
Pushed by philringnalda@gmail.com:
https://hg.mozilla.org/mozilla-central/rev/14b5800c284e
disable test_password_field_autocomplete.html on Linux for constant failures, a=nnoyance
https://hg.mozilla.org/mozilla-central/rev/14b5800c284e

Comment 12

8 months ago
20 failures in 113 pushes (0.177 failures/push) were associated with this bug yesterday.  

Repository breakdown:
* mozilla-aurora: 5
* mozilla-inbound: 4
* autoland: 4
* mozilla-central: 3
* graphics: 3
* try: 1

Platform breakdown:
* linux64: 12
* linux32: 8

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1317284&startday=2016-11-18&endday=2016-11-18&tree=all
status-firefox50: --- → unaffected
status-firefox51: --- → unaffected
status-firefox52: --- → affected
status-firefox53: --- → affected

Comment 13

8 months ago
324 failures in 715 pushes (0.453 failures/push) were associated with this bug in the last 7 days. 

This is the #2 most frequent failure this week. 

** This failure happened more than 50 times this week! Resolving this bug is a high priority. **

Repository breakdown:
* mozilla-inbound: 131
* autoland: 105
* try: 34
* mozilla-aurora: 28
* mozilla-central: 17
* graphics: 9

Platform breakdown:
* linux64: 253
* linux32: 71

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1317284&startday=2016-11-14&endday=2016-11-20&tree=all
Comment on attachment 8811126 [details]
Bug 1317284 - Fix the intermittent failed in test_password_field_autocomplete.html.;

https://reviewboard.mozilla.org/r/93354/#review94422

::: toolkit/components/passwordmgr/LoginManagerContent.jsm
(Diff revision 1)
> -  Services.prefs.addObserver("security.insecure_field_warning.contextual.enabled",
> -                             this.updateWithPrefChange.bind(this), false);
> -
> -  Services.prefs.addObserver("signon.autofillForms.http",
> -                             this.updateWithPrefChange.bind(this), false);

It's unfortunate that this will leave a function (updateWithPrefChange) with one caller when it wasn't a function before.

::: toolkit/components/passwordmgr/test/mochitest/test_password_field_autocomplete.html:114
(Diff revision 1)
>    let temp = form.innerHTML;
>    form.innerHTML = "";
>    form.innerHTML = temp;
> +
> +  yield new Promise(resolve => {
> +    var observer = SpecialPowers.wrapCallback(() => {

Nit: use `let`
Attachment #8811126 - Flags: review?(MattN+bmo) → review+
Comment on attachment 8811126 [details]
Bug 1317284 - Fix the intermittent failed in test_password_field_autocomplete.html.;

https://reviewboard.mozilla.org/r/93354/#review94424

::: toolkit/components/passwordmgr/test/mochitest/test_password_field_autocomplete.html:96
(Diff revision 1)
>  
>  </div>
>  
>  <pre id="test">
>  <script class="testbody" type="text/javascript">
>  

Don't forget to revert https://hg.mozilla.org/mozilla-central/rev/14b5800c284e too
Comment hidden (mozreview-request)
(Assignee)

Comment 17

8 months ago
Leave a try link for the latest patch in comment 16:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0d59012e8dfed75b5163f878a267c950d635296f

Comment 18

8 months ago
26 failures in 623 pushes (0.042 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* mozilla-aurora: 25
* try: 1

Platform breakdown:
* linux64: 14
* linux32: 12

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1317284&startday=2016-11-21&endday=2016-11-27&tree=all
Comment on attachment 8811126 [details]
Bug 1317284 - Fix the intermittent failed in test_password_field_autocomplete.html.;

Approval Request Comment
[Feature/Bug causing the regression]: Regression, bug 1289913.
[User impact if declined]: None.
[Is this code covered by automated tests?]: Yes.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: See dependency.
[Is the change risky?]: No.
[Why is the change risky/not risky?]: This is a test script only fix that would fix a test that got merged into Aurora.
[String changes made/needed]: No.
Attachment #8811126 - Flags: approval-mozilla-aurora?

Comment 20

8 months ago
28 failures in 694 pushes (0.04 failures/push) were associated with this bug in the last 7 days. 

This is the #50 most frequent failure this week. 

Repository breakdown:
* mozilla-aurora: 28

Platform breakdown:
* linux64: 16
* linux32: 12

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1317284&startday=2016-11-28&endday=2016-12-04&tree=all
Comment hidden (mozreview-request)
(Assignee)

Comment 22

8 months ago
Comment on attachment 8811126 [details]
Bug 1317284 - Fix the intermittent failed in test_password_field_autocomplete.html.;

Hi MattN,

This patch is with the following changes:
1. Add pushPrefEnv for readonly and disabled cases.
2. Move readonly and disabled cases from the bottom to after test_form1_initial_empty. This can resolve another intermittent failed.

Could you review it again? Thanks.
Attachment #8811126 - Flags: review+ → review?(MattN+bmo)
(Assignee)

Comment 23

8 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=94978930f3656fb3143d875f578205d7cb004e62

Comment 24

7 months ago
7 failures in 289 pushes (0.024 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* mozilla-aurora: 7

Platform breakdown:
* linux64: 6
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1317284&startday=2016-12-05&endday=2016-12-11&tree=all
(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #19)
> [Has the fix been verified in Nightly?]: Yes.

I'm confused.  This patch doesn't seem to have landed in nightly?
Flags: needinfo?(timdream)
Comment on attachment 8811126 [details]
Bug 1317284 - Fix the intermittent failed in test_password_field_autocomplete.html.;

My mistake. I was trying to fill the form in advanced so this don't get blocked. Let's re-request again only after it gets landed.
Flags: needinfo?(timdream)
Attachment #8811126 - Flags: approval-mozilla-aurora?
Is this ready to land Sean?  Or are you waiting on Matt's review?
Flags: needinfo?(selee)
Keywords: regressionwindow-wanted
Sorry, wrong bug.
Keywords: regressionwindow-wanted
(Assignee)

Comment 29

7 months ago
Hi Tanvi, yes, I am waiting for MattN's review.

Hi MattN, could you help to review the patch again? There are some changes to fix another test failed since the last R+ you gave. Thanks.
Flags: needinfo?(selee) → needinfo?(MattN+bmo)
Comment hidden (mozreview-request)
(Assignee)

Comment 31

7 months ago
Try result for the latest patch:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1fbf18bfe4b6e30a59d6e8db1329ad611eb31fa6
status-firefox52: affected → fix-optional
Comment on attachment 8811126 [details]
Bug 1317284 - Fix the intermittent failed in test_password_field_autocomplete.html.;

https://reviewboard.mozilla.org/r/93354/#review106502

::: toolkit/components/passwordmgr/LoginManagerContent.jsm
(Diff revision 4)
> -  this.searchString = aSearchString;
> -
> -  this._stringBundle = Services.strings.createBundle("chrome://passwordmgr/locale/passwordmgr.properties");
> -  this._dateAndTimeFormatter = new Intl.DateTimeFormat(undefined,
> -                              { day: "numeric", month: "short", year: "numeric" });
> -
> -  this._messageManager = messageManager;
> -  this._matchingLogins = matchingLogins;

This unnecessary code movement made the patch really hard to review and is why it took so long. I kept looking at the patch and not wanting to waste the time untangling what was happening here. In the future use a separate commit for significant code movement that's unrelated to the bug.
Attachment #8811126 - Flags: review?(MattN+bmo) → review+
Flags: needinfo?(MattN+bmo)
(Assignee)

Updated

6 months ago
Keywords: checkin-needed
Keywords: checkin-needed
Whiteboard: [test disabled on Linux]
https://hg.mozilla.org/integration/mozilla-inbound/rev/fabf199ceca6

Comment 34

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fabf199ceca6
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Please request Aurora approval on this when you get a chance. Also note that the patch will need rebasing for uplift.
Flags: needinfo?(selee)
Comment on attachment 8811126 [details]
Bug 1317284 - Fix the intermittent failed in test_password_field_autocomplete.html.;

Approval Request Comment
[Feature/Bug causing the regression]: bug 1289913
[User impact if declined]: Blocks uplift of other insecure password warning fixes/tests
[Is this code covered by automated tests?]: This is a test
[Has the fix been verified in Nightly?]: Not directly but it's mostly a test change and QA is regularly testing this feature now.
[Needs manual test from QE? If yes, steps to reproduce]:  No
[List of other uplifts needed for the feature/fix]: This blocks uplift of bug 1329351
[Is the change risky?]: No, 
[Why is the change risky/not risky?]: Non-test change is mostly refactoring to got back to an older method
[String changes made/needed]: None
Flags: needinfo?(selee)
Attachment #8811126 - Flags: approval-mozilla-aurora?
status-firefox52: fix-optional → affected
status-firefox54: --- → fixed
Comment on attachment 8811126 [details]
Bug 1317284 - Fix the intermittent failed in test_password_field_autocomplete.html.;

This now needs beta approval due to the merge.
Attachment #8811126 - Flags: approval-mozilla-beta?
Attachment #8811126 - Flags: approval-mozilla-aurora?
Comment on attachment 8811126 [details]
Bug 1317284 - Fix the intermittent failed in test_password_field_autocomplete.html.;

fix an intermittent in beta52, should be in b2
Attachment #8811126 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
As mentioned in comment 35, this needs rebasing for Beta uplift.
Flags: needinfo?(selee)
I'm rebasing now
https://hg.mozilla.org/releases/mozilla-beta/rev/3861c5f62b18
status-firefox52: affected → fixed
Rebasing was only due to eslint changes.
Flags: needinfo?(selee)
You need to log in before you can comment on or make changes to this bug.