1317289 - Scope error displayed after signing in under certain circumstances

Status: RESOLVED FIXED

(Taskcluster :: UI, defect)

Description

[Greg Arndt [:garndt]]

After selecting an action on one of the tools sites when not logged in, such as clicking a worker type in the aws-provisioner UI, the user is presented with an error informing them of this.  However, after logging in and being redirected back to the originating site, a scope error is displayed.  Navigating away from where the user was at originally and going back resolves the issue.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

I think the issue is that we don't automatically re-try operations, or hide error messages, on login.  Probably hiding the error message is not a bad idea, and for cases where visibility is based on scopes (aws provisioner, secrets) retrying the GET call.

Comment 2

[Hashini Galappaththi]

May  I start working on this ?

Comment 3

[Hassan Ali (:hassan)]

One area where this happens is in the aws-provisioner view:

STR:

1. Navigate to https://tools.taskcluster.net/aws-provisioner
2. Make sure you are not logged in 
3. Click on a worker type (e.g., ami-test)
4. You will see an error. Click on "Additional details...".
5. Login

Expected: The GET call for the worker type is retried. The error might still show if you don't have enough permissions but when you click on "Additional details..." your scopes should not be empty "[]" anymore.

Actual: The GET call is not retried and the same error is shown:

"You do not have sufficient scopes. This request requires you to have one of the following sets of scopes: [ [ "aws-provisioner:view-worker-type:ami-test" ], [ "aws-provisioner:manage-worker-type:ami-test" ] ]

You only have the scopes: []"

Comment 4

[Hashini Galappaththi]

The root cause for the bug is in the “componentWillReceiveProps” method in the “WorkerTypeView” component found in “src/views/AwsProvisioner/WorkerTypeView.js”

This is the root cause for “loadWorkerType” GET call for the worker type is not executed when a user logs in or changes. Also note that the GET call is only executed if “provisionerId” or “workerType” type changes. Moreover there is no clearing of the error in “this.state”.

Comment 5

[Hassan Ali (:hassan)]

Awesome! Thanks for looking into the issue. The next step is to create a pull-request with the fix so we can review it. Let me know if you need help along the way :)

Comment 6

[Hashini Galappaththi]

I have created a pull request. Link: https://github.com/taskcluster/taskcluster-tools/pull/454

I am not able to add you as a reviewer.

Comment 7

[Hashini Galappaththi]

I put my findings for the, PR changes requested. Could you please have a look.

Comment 8

[Hassan Ali (:hassan)]

Thanks Hashini, awesome job!

Comment 9

[[github robot]]

Commit pushed to master at https://github.com/taskcluster/taskcluster-tools

https://github.com/taskcluster/taskcluster-tools/commit/b6097065120024dda58a5c20c1efe3ceababc388
Bug 1317289 - Scope error displayed after signing in under certain circumstances