Closed Bug 1317292 Opened 3 years ago Closed 3 years ago

Optimize CacheIR register spilling

Categories

(Core :: JavaScript Engine: JIT, defect, P5)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: jandem, Unassigned)

References

(Blocks 1 open bug)

Details

See the last part of bug 1310125 comment 7.

CacheRegisterAllocator::allocateFixedRegister currently just spills any operand that is using the register to the stack. It could be a bit smarter and try to move it into another register instead.

I think these optimizations will be especially nice once Ion ICs use CacheIR and CacheRegisterAllocator.
Priority: -- → P5
Bug 1322093 fixed the allocateFixedRegister thing in comment 0. If the register is in use, allocateFixedRegister now calls spillOperandToStackOrRegister (which tries to use an available register).

We can file new bugs if we notice other issues.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.