Closed Bug 1317308 Opened 3 years ago Closed 3 years ago

\s should no longer match U+180E in regular expressions

Categories

(Core :: JavaScript: Standard Library, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox52 --- wontfix
firefox53 --- fixed

People

(Reporter: anba, Assigned: anba)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

`assertEq(/\s/.exec("\u180e"), null)` should pass.
Attached patch bug1317308.patchSplinter Review
We should probably generate the constants in irregexp/RegExpEngine.cpp through vm/make_unicode.py, but for now this quick fix should suffice.
Attachment #8810530 - Flags: review?(arai.unmht)
Comment on attachment 8810530 [details] [diff] [review]
bug1317308.patch

Review of attachment 8810530 [details] [diff] [review]:
-----------------------------------------------------------------

Great!
yeah, I agree that the table should be automatically generated.
Attachment #8810530 - Flags: review?(arai.unmht) → review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/94615002eb6e
Don't match Mongolian vowel separator as white space in regular expressions. r=arai
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/94615002eb6e
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.