1317330 - Increase Marionette log level for non-Windows systems

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Andreas Tolfsen ❲:ato❳]

As of bug 1311116 the default logging output from debug builds will be reduced to Log.Level.Info instead of Log.Level.Trace.  We should ensure that the detailed log level is kept for try runs by either setting the marionette.logging preference or passing the -vv flag to ./mach marionette-test.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1317330 - Increase Mn verbosity for all mozharness initiated runs;

Following bug 1311116 which reduces the Marionette log verbosity for local
builds, this increases it on on all try jobs through passing the `-vv`
(very verbose, equating to `Log.Level.Trace`) flag to the Marionette
test harness.

Review commit: https://reviewboard.mozilla.org/r/92750/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92750/

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8810426 [details]
Bug 1317330 - Increase Mn verbosity for all mozharness initiated runs;

https://reviewboard.mozilla.org/r/92750/#review92728

My objection on the other bug was not only related to get this enabled for try but all integration and release branches. A change like this will make it happen for all kind of builds across all branches, and not only for debug and maybe ASAN as we talked on IRC.

Given that you mentioned that folks were not happy with the larger log files, I would like to see feedback first which shows their acceptance of this change.

Comment 3

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8810426 [details]
Bug 1317330 - Increase Mn verbosity for all mozharness initiated runs;

https://reviewboard.mozilla.org/r/92750/#review92728

I’m happy to make that change and await and see if it is a real problem for consumers.  If it is, we can address it with a more complicated solution that selects on build type.

Comment 4

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8810426 [details]
Bug 1317330 - Increase Mn verbosity for all mozharness initiated runs;

The try runs here look okay.  I notice that both TC and Buildbot split out gecko.log as a separate file and that Mn uses structured logging.  I believe with this advancement, we are in a good position to merge this.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8810426 [details]
Bug 1317330 - Increase Mn verbosity for all mozharness initiated runs;

https://reviewboard.mozilla.org/r/92750/#review92728

I have checked the sizes of gecko.log files with this change for opt and debug builds on Linux and those do not really differ. It's 6.8MB to 7.2MB. Given that we gzip the log files we have a pretty good compression level due to lots of duplicated strings. It means that the logs will end-up on S3 with about 700kB. That's a huge increase from 13kB.

Technically the patch is correct, but before landing please request feedback from some TC, releng, and Treeherder folks.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8810426 [details]
Bug 1317330 - Increase Mn verbosity for all mozharness initiated runs;

https://reviewboard.mozilla.org/r/92750/#review93056

Comment 7

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8810426 [details]
Bug 1317330 - Increase Mn verbosity for all mozharness initiated runs;

dustin: Bug 1311116 reduced the default logging level of Marionette for local debug builds, and this patch raises the logging verbosity for all builds.  This extra logging ends up in gecko.log and can be useful when debugging Marionette-related problems.

Are you happy with this?

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Andreas Tolfsen ‹:ato› from comment #7)
> Are you happy with this?

For feedback please also take comment 5 into account.

Comment 9

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8810426 [details]
Bug 1317330 - Increase Mn verbosity for all mozharness initiated runs;

Our purpose is to provide useful information to developers, not save a few hundred dollars in S3 costs, so, yeah, looks good to me.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/429e0bd037aa
Increase Mn verbosity for all mozharness initiated runs; r=whimboo

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/429e0bd037aa

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As just noticed this patch was incomplete and only enabled tracing output for non-Windows builds. There are some more config files for mozharness which need that fix. I will file a follow-up bug.