Closed
Bug 1317344
Opened 8 years ago
Closed 8 years ago
Remove unused Marionette configs from mozharness
Categories
(Release Engineering :: Applications: MozharnessCore, defect)
Release Engineering
Applications: MozharnessCore
Tracking
(firefox52 fixed, firefox53 fixed)
RESOLVED
FIXED
People
(Reporter: ato, Assigned: ato)
References
Details
Attachments
(1 file, 4 obsolete files)
testing/mozharness/configs/marionette/prod_config.py lists a number of mozharness configurations for Marionette that are no longer in use.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 10•8 years ago
|
||
There is more than this single config file where we have to get all the individual Marionette suites removed. Also it would be good to also get the mozharness script updated accordingly. https://dxr.mozilla.org/mozilla-central/search?q=gaiatest_desktop&=mozilla-central https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/scripts/marionette.py
Assignee | ||
Comment 11•8 years ago
|
||
That should probably be addressed in this bug.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Attachment #8810431 -
Attachment is obsolete: true
Attachment #8810431 -
Flags: review?(hskupin)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Updated•8 years ago
|
Attachment #8810430 -
Flags: review?(hskupin)
Attachment #8810432 -
Flags: review?(hskupin)
Attachment #8810433 -
Flags: review?(hskupin)
Attachment #8810434 -
Flags: review?(hskupin)
Comment 24•8 years ago
|
||
Sorry, for removing all the review flags. I didn't notice that this bug only covers the config part. Can you please update the commit messages to make it clear? Also I would love to see a single changeset here. No need to split this up into 4 different ones.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Attachment #8810432 -
Attachment is obsolete: true
Assignee | ||
Updated•8 years ago
|
Attachment #8810433 -
Attachment is obsolete: true
Assignee | ||
Updated•8 years ago
|
Attachment #8810434 -
Attachment is obsolete: true
Comment 26•8 years ago
|
||
mozreview-review |
Comment on attachment 8810430 [details] Bug 1317344 - Remove unused Marionette configs from mozharness; https://reviewboard.mozilla.org/r/92754/#review94288 There is one thing which is not clear to me. Please see the created issue. Otherwise you removed gaia_test.py, and there is still a reference to this file in a comment of script.py for _retry_download(). You may want to remove that too given that it doesn't apply anymore. ::: testing/mozharness/configs/marionette/prod_config.py (Diff revision 5) > "--symbols-path=%(symbols_path)s" > ], > "run_filename": "", > "testsdir": "" > - }, > - "marionette_emulator": { Why are you removing the emulator configs here while they remain in the other config files? Do we need those or not?
Attachment #8810430 -
Flags: review?(hskupin) → review-
Comment hidden (mozreview-request) |
Assignee | ||
Comment 28•8 years ago
|
||
mozreview-review-reply |
Comment on attachment 8810430 [details] Bug 1317344 - Remove unused Marionette configs from mozharness; https://reviewboard.mozilla.org/r/92754/#review94288 Fixed. > Why are you removing the emulator configs here while they remain in the other config files? Do we need those or not? Found a few more references and also deleted automation_emulator_config.py.
Comment 29•8 years ago
|
||
mozreview-review |
Comment on attachment 8810430 [details] Bug 1317344 - Remove unused Marionette configs from mozharness; https://reviewboard.mozilla.org/r/92754/#review94680 Looks fine to me now. I also checked the buildbot-configs repository for possible traces but wasn't able to find any. So we do not need a follow-up.
Attachment #8810430 -
Flags: review?(hskupin) → review+
Comment 30•8 years ago
|
||
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4178396a8da0 Remove unused Marionette configs from mozharness; r=whimboo
Comment 31•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4178396a8da0
Comment 33•7 years ago
|
||
To reduce the amount of work necessary for uplifts (to fix merge conflicts) it would be great to get this test-only patch uplifted to Aurora, so it reaches the next ESR. Thanks.
status-firefox52:
--- → affected
Whiteboard: [checkin-needed-aurora]
Comment 34•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/87baf4416d37
Updated•7 years ago
|
Whiteboard: [checkin-needed-aurora]
You need to log in
before you can comment on or make changes to this bug.
Description
•