Closed Bug 1317351 Opened 3 years ago Closed 3 years ago

<button> and <input type=color> have huge width with vertical writing-mode

Categories

(Core :: Layout: Form Controls, defect, P4, minor)

defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox52 --- wontfix
firefox53 --- fixed

People

(Reporter: mats, Assigned: mats)

Details

(Keywords: testcase)

Attachments

(3 files)

Attached file testcase
The reason is we're subtracting border/padding from a NS_UNCONSTRAINEDSIZE
and later using that as a percentage basis for the button children.
Attached patch reftestSplinter Review
(fixed s/its/it's/ in the commit message locally)
Comment on attachment 8810670 [details] [diff] [review]
Make CloneReflowInputWithReducedContentBox use logical coordinates, which avoids doing math on NS_UNCONSTRAINEDSIZE ComputedWidth() when its an unconstrained block-size.

Review of attachment 8810670 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks.
Attachment #8810670 - Flags: review?(jfkthame) → review+
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e4e19a28e8af
Make CloneReflowInputWithReducedContentBox use logical coordinates, which avoids doing math on NS_UNCONSTRAINEDSIZE ComputedWidth() when it's an unconstrained block-size.  r=jfkthame
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e3043cf0b4d
Reftest.
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/e4e19a28e8af
https://hg.mozilla.org/mozilla-central/rev/2e3043cf0b4d
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.