Closed Bug 1317384 Opened 4 years ago Closed 3 years ago
Array%.prototype .set should use To Integer instead of To Int32
For example `new Int8Array(10).set(, -Infinity)` should throw a RangeError. ES2017 spec: https://tc39.github.io/ecma262/#sec-%typedarray%.prototype.set-overloaded-offset The following test262 tests are currently failing because of this issue: built-ins/TypedArray/prototype/set/array-arg-negative-integer-offset-throws.js built-ins/TypedArray/prototype/set/typedarray-arg-negative-integer-offset-throws.js built-ins/TypedArray/prototype/set/typedarray-arg-src-range-greather-than-target-throws-rangeerror.js
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Attachment #8834372 - Flags: review?(lhansen)
I forgot to mention that the patch applies on top of bug 1225031.
Comment on attachment 8834372 [details] [diff] [review] bug1317384.patch Review of attachment 8834372 [details] [diff] [review]: ----------------------------------------------------------------- I bow down in awe for some of those tests.
Attachment #8834372 - Flags: review?(lhansen) → review+
(In reply to Lars T Hansen [:lth] from comment #3) > I bow down in awe for some of those tests. It may make sense to contribute them to test262, but I'd have to check the existing coverage for %TypedArray%.prototype.set() first.
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4a930acd18f8 Update TypedArray.prototype.set to be compliant with latest ECMA2017. r=lth
You need to log in before you can comment on or make changes to this bug.