Closed Bug 131739 Opened 22 years ago Closed 22 years ago

unable to double-click to select word

Categories

(SeaMonkey :: Composer, defect)

Product:
SeaMonkey
Component:
Composer
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.0

People

(Reporter: Brade, Assigned: cmanske)

References

Details

(Keywords: regression)

Attachments

(1 file, 3 obsolete files)

Update #3
3.96 KB, patch
Brade
: review+
scc
: superreview+
asa
: approval+
Details | Diff | Splinter Review 
I am unable to double-click to select a word.
I expect the word to select but nothing happens.
This is a regression.
Keywords: regression
OS: Mac System 9.x → All
Hardware: Macintosh → All
Summary: unable to double-click to select word. → unable to double-click to select word
Target Milestone: --- → mozilla1.0
Status: NEW → ASSIGNED
Whiteboard: nsbeta1
Attached patch Fix (obsolete) — — Splinter Review 
We must not stop event bubbling all the time for double click,
only when we have selected an element.
Fall through to do word-selection when clicking on text.
Keywords: nsbeta1, patch, review
Whiteboard: nsbeta1 → FIX IN HAND, need r=,sr=
Comment on attachment 74760 [details] [diff] [review]
Fix

r = jfrancis
Attachment #74760 - Flags: review+
Attached patch Updated fix (obsolete) — — Splinter Review 
Cleaned up logic after discussing with reviewers.
This avoids doing both selection->Collapse()
and selecting the element. 
Simlifies when to call preventDefault.
Attachment #74760 - Attachment is obsolete: true
Attached patch Update fix #2 (obsolete) — — Splinter Review 
Same as previous, but changed "if ( !(buttonNumber == 0 && clickCount == 2)"
to "if (isContextClick)" since this is all within the block:
if (isContextClick || (buttonNumber == 0 && clickCount == 2))
Attachment #74783 - Attachment is obsolete: true
cc: tucson/smoketester
Comment on attachment 74786 [details] [diff] [review]
Update fix #2

r=brade
Attachment #74786 - Flags: review+
*** Bug 132128 has been marked as a duplicate of this bug. ***
Comment on attachment 74786 [details] [diff] [review]
Update fix #2

looks like you're missing some or-bars after the node-type tests for "th" and
"tr"
Whiteboard: FIX IN HAND, need r=,sr= → FIX IN HAND, need sr=
Attached patch Update #3 — — Splinter Review 
Fixed missing "||" found by scc
Attachment #74786 - Attachment is obsolete: true
Comment on attachment 75186 [details] [diff] [review]
Update #3

sr=scc
Attachment #75186 - Flags: superreview+
Comment on attachment 75186 [details] [diff] [review]
Update #3

r=brade
Attachment #75186 - Flags: review+
Comment on attachment 75186 [details] [diff] [review]
Update #3

a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #75186 - Flags: approval+
checked in
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Keywords: patch, review
Resolution: --- → FIXED
Whiteboard: FIX IN HAND, need sr=
verified in 3/21 build.

working now...
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: