1317394 - DataView.prototype.byteLength and byteOffset should throw when the underlying buffer is detached

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, defect)

Description

[André Bargull [:anba]]

Test case:
---
var ab = new ArrayBuffer(10);
var dv = new DataView(ab)
detachArrayBuffer(ab);
dv.byteLength; // Or: dv.byteOffset;
---

Expected: Throws TypeError
Actual: No exception thrown


Also see bug 1079853.

Comment 1

[Tom S [:evilpie]]

Attachment: Throw on detached ArrayBuffer in DataView getters

Somehow I never uploaded this patch, but I think there is nothing wrong with it.

Comment 2

[André Bargull [:anba]]

Comment on attachment 8906269 [details] [diff] [review]
Throw on detached ArrayBuffer in DataView getters

Review of attachment 8906269 [details] [diff] [review]:
-----------------------------------------------------------------

Nothing wrong with the patch itself, but I'm wondering about web-compatibility. AFAICS, no other browser is currently throwing a TypeError for detached buffers in the byteLength and byteOffset getters. Do you think it's still okay to let this change ride the trains to release, or is it more safe to restrict it to nightly+beta for a longer time until we're sure it won't break web-sites?

Comment 3

[Tom S [:evilpie]]

Oh, maybe that's why I never bothered with this. My feeling tells me DataView aren't actually used much and detached array buffers are probably also not that common. Making it Nightly only at least for the 57 cycle sounds like a good idea anyway.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a31657380189
Make DataView getters throw for detached array buffers in Nightly. r=anba

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b7f103d256b9
Fix bustage on CLOSED TREE by changing an old test.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a31657380189
https://hg.mozilla.org/mozilla-central/rev/b7f103d256b9